Bugzilla – Attachment 40648 Details for
Bug 14440
get_template_and_user can not have an empty template_name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[3.18.x] Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl)
318x-Bug-14440-gettemplateanduser-can-not-have-an-.patch (text/plain), 3.38 KB, created by
Katrin Fischer
on 2015-06-26 08:00:25 UTC
(
hide
)
Description:
[3.18.x] Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl)
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-06-26 08:00:25 UTC
Size:
3.38 KB
patch
obsolete
>From a32c8392fa254566c27e4d8c8cd605c69ce7162b Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 23 Jun 2015 17:45:30 +0200 >Subject: [PATCH] [3.18.x] Bug 14440: get_template_and_user can not have an > empty template_name (opac-ratings.pl) > >Since Bug 14408, the method get_template_and_user can not have an empty template_name. >Pages calling with an empty value should use C4::Auth::checkauth() > >This patch corrects opac/opac-ratings.pl > >Test plan : >- Apply patch >- Set sysopref OpacStarRatings to 'results and details' >- Disable Javascipt on your browser (otherwise it will use ajax) >- Login at OPAC >- Go to a record >- Click on a button left of 'Rate me' to choose a rating, ie 4 >- Click on 'Rate me' >=> The page is reloaded and you see 'your rating: 4' >- Loggout from OPAC >- Try to access URL : http://<serveur>/cgi-bin/koha/opac-ratings.pl >=> You see the loggin page > >Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> > >Conflicts: > opac/opac-ratings.pl >--- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1 - > opac/opac-ratings.pl | 18 +++++------------- > 2 files changed, 5 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index cef795d..a4db023 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -485,7 +485,6 @@ > <!-- define some hidden vars for ratings --> > > <input type="hidden" name='biblionumber' value="[% biblionumber %]" /> >- <input type="hidden" name='borrowernumber' value="[% borrowernumber %]" /> > <input type="hidden" name='rating_value' id='rating_value' value="[% rating_value %]" /> > <input type="hidden" name='rating_total' id='rating_total' value="[% rating_total %]" /> > <input type="hidden" name='rating_avg_int' id='rating_avg_int' value="[% rating_avg_int %]" /> >diff --git a/opac/opac-ratings.pl b/opac/opac-ratings.pl >index d38c5e4..cf83191 100755 >--- a/opac/opac-ratings.pl >+++ b/opac/opac-ratings.pl >@@ -28,8 +28,7 @@ note: there is currently no 'delete rating' functionality in this script > use strict; > use warnings; > use CGI; >-use CGI::Cookie; >-use C4::Auth qw(:DEFAULT check_cookie_auth); >+use C4::Auth; > use C4::Context; > use C4::Output; > use C4::Dates qw(format_date); >@@ -38,17 +37,10 @@ use C4::Ratings; > use C4::Debug; > > my $query = CGI->new(); >-my $a = $query->Vars; >-#### $a >-my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >- { >- template_name => "", >- query => $query, >- type => "opac", >- authnotrequired => 0, # auth required to add tags >- debug => 0, >- } >-); >+ >+# auth required to add ratings >+my ($userid, $cookie, $sessionID) = checkauth( $query, 0, {}, 'opac' ); >+my $loggedinuser = C4::Context->userenv->{'number'}; > > my $biblionumber = $query->param('biblionumber'); > my $rating_old_value = $query->param('rating_value'); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14440
:
40533
|
40544
|
40546
|
40559
|
40595
|
40600
|
40601
|
40602
|
40607
|
40608
|
40609
|
40620
|
40621
|
40622
| 40648