Attachment 4070 Details for Bug 4994 – Signed off patch

[patch] Signed off patch

0002-Bug-4994-Net-LDAP-returns-lowercase-names.patch (text/plain), 1.39 KB, created by Chris Cormack on 2011-05-09 22:06:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-05-09 22:06:33 UTC

Size: 1.39 KB

patch

obsolete

>From 9a02439414f6f4148ce8db909984ce1c93cb4e84 Mon Sep 17 00:00:00 2001
>From: Dobrica Pavlinusic <dpavlin@rot13.org>
>Date: Tue, 13 Jul 2010 23:26:35 +0200
>Subject: [Signed Off] [PATCH] Bug 4994 - Net::LDAP returns lowercase names
>
>This requires us to specify all LDAP mappings in koha-conf.xml in lowercase,
>instead of original case used withing LDAP.
>
>Compare readability of
>
><userid      is="hrEduPersonUniqueID"  ></userid>
>
>(which doesn't work) with required (and non-intuitive)
>
><userid      is="hredupersonuniqueid"  ></userid>
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> C4/Auth_with_ldap.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm
>index 3613acf..02f664b 100644
>--- a/C4/Auth_with_ldap.pm
>+++ b/C4/Auth_with_ldap.pm
>@@ -210,7 +210,7 @@ sub ldap_entry_2_hash ($$) {
> 	$debug and print STDERR "Finsihed \%memberhash has ", scalar(keys %memberhash), " keys\n",
> 					"Referencing \%mapping with ", scalar(keys %mapping), " keys\n";
> 	foreach my $key (keys %mapping) {
>-		my  $data = $memberhash{$mapping{$key}->{is}}; 
>+		my  $data = $memberhash{ lc($mapping{$key}->{is}) }; # Net::LDAP returns all names in lowercase
> 		$debug and printf STDERR "mapping %20s ==> %-20s (%s)\n", $key, $mapping{$key}->{is}, $data;
> 		unless (defined $data) { 
> 			$data = $mapping{$key}->{content} || '';	# default or failsafe ''
>-- 
>1.7.4.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 4994: 2359 | 4070