Bugzilla – Attachment 40759 Details for
Bug 11250
"too many holds" message appears inappropriately
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11250 - "too many holds" message appears inappropriately
Bug-11250---too-many-holds-message-appears-inappro.patch (text/plain), 3.08 KB, created by
Kyle M Hall (khall)
on 2015-07-02 10:09:37 UTC
(
hide
)
Description:
Bug 11250 - "too many holds" message appears inappropriately
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-07-02 10:09:37 UTC
Size:
3.08 KB
patch
obsolete
>From dc6c27ef90eab6342f902dd3c3e09eaeca34bbe0 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 2 Jul 2015 05:29:06 -0400 >Subject: [PATCH] Bug 11250 - "too many holds" message appears inappropriately > >This patch gives the various reasons precedence in this order: >1) Already in possesion >2) Already on hold >3) Age restricted >4) No items available >5) Too many holds > >Test Plan: >1) Attempt to place a hold where both "too many holds" and "no items available" messages display >2) Apply this patch >3) Refresh >4) Note only the "no items available" message displays >--- > .../prog/en/modules/reserve/request.tt | 22 ++++++++----------- > 1 files changed, 9 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 80be359..f32a2bf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -303,20 +303,16 @@ function checkMultiHold() { > [% UNLESS ( multi_hold ) %] > <h3>Cannot place hold</h3> > <ul> >- [% IF ( maxreserves ) %] >- <li><strong>Too many holds: </strong> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many holds.</li> >- [% END %] >- [% IF ( ageRestricted ) %] >- <li><strong>Age restricted</strong></li> >- [% END %] >- [% IF ( alreadyreserved ) %] >- <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> >- [% END %] >- [% IF ( none_available ) %] >- <li> <strong>No items are available</strong> to be placed on hold</li> >- [% END %] > [% IF ( alreadypossession ) %] > <li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>is already in possession</strong> of one item</li> >+ [% ELSIF ( alreadyreserved ) %] >+ <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> >+ [% ELSIF ( ageRestricted ) %] >+ <li><strong>Age restricted</strong></li> >+ [% ELSIF ( none_available ) %] >+ <li> <strong>No items are available</strong> to be placed on hold</li> >+ [% ELSIF ( maxreserves ) %] >+ <li><strong>Too many holds: </strong> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many holds.</li> > [% END %] > </ul> > [% ELSE %] >@@ -802,7 +798,7 @@ function checkMultiHold() { > <img src="[% interface %]/[% theme %]/img/go-down.png" border="0" alt="Set to lowest priority" /> > [% END %] > </a> >- </td> >+ </td> > [% END %] > > <td> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11250
:
40759
|
42657
|
43748