Bugzilla – Attachment 40784 Details for
Bug 14487
Warns from returns.pl during checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14487 - silence warns during checkin
Bug-14487---silence-warns-during-checkin.patch (text/plain), 1.29 KB, created by
Mark Tompsett
on 2015-07-03 21:05:52 UTC
(
hide
)
Description:
Bug 14487 - silence warns during checkin
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-07-03 21:05:52 UTC
Size:
1.29 KB
patch
obsolete
>From f482f7b84d7e6d44d3cdf9a1aadfef86ba9056ce Mon Sep 17 00:00:00 2001 >From: Indranil Das Gupta <indradg@gmail.com> >Date: Fri, 3 Jul 2015 13:33:06 +0530 >Subject: [PATCH] Bug 14487 - silence warns during checkin > >Test plan >========= > >1/ check out an item and then check it back in. >1/ check the logs after the check-in to see the warns from > returns.pl line 623 of : > (a) Use of uninitialized value $holdingBranch > (b) Use of uninitialized value $collectionBranch >2/ apply patch >3/ check out and check-in again. no warns are recorded this time. > >NOTE: Under Debian Jessie, there are other messages. > Additionally, this only corrects the line 623 ones. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > circ/returns.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/circ/returns.pl b/circ/returns.pl >index c36318f..91a6857 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -620,6 +620,8 @@ $template->param( > $itemnumber = GetItemnumberFromBarcode( $query->param('barcode') ); > if ( $itemnumber ) { > my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); >+ $holdingBranch //= ''; >+ $collectionBranch //= ''; > if ( ! ( $holdingBranch eq $collectionBranch ) ) { > $template->param( > collectionItemNeedsTransferred => 1, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14487
:
40773
|
40783
|
40784
|
40785
|
40788
|
41082
|
41083
|
41173
|
41174