Bugzilla – Attachment 40851 Details for
Bug 14259
OPAC system preference BiblioDefaultView is ignored
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14259: OPAC system preference BiblioDefaultView is ignored
Bug-14259-OPAC-system-preference-BiblioDefaultView.patch (text/plain), 6.43 KB, created by
Mark Tompsett
on 2015-07-09 00:27:38 UTC
(
hide
)
Description:
Bug 14259: OPAC system preference BiblioDefaultView is ignored
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-07-09 00:27:38 UTC
Size:
6.43 KB
patch
obsolete
>From 32c008f8bbdfbcb9055595e856ad0424d319894c Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 8 Jul 2015 15:15:09 -0400 >Subject: [PATCH] Bug 14259: OPAC system preference BiblioDefaultView is > ignored > >Cover image links ignore the BiblioDefaultView value for non-XSLT. >XSLT was corrected in 12574. > >TEST PLAN >--------- > 1) Back up your database > 2) drop you db and do a fresh install of the sample data > 3) set koha admin to a super librarian, and set up a username > and password for it. > 4) catalog "The Road To Character" by David Brooks. > 5) using koha admin import a small set of data. > 6) stop zebra and do a full reindex then restart it. > 7) Change the 'OPACXSLTDetailsDisplay' and 'OPACXSLTResultsDisplay' > system preferences to blank! > -- This corrects the non-XSLT things missed by 12574. > 7) Change the 'GoogleJackets' system preference to 'Add'. > 8) Change the 'BiblioDefaultView' system preference to > 'in their MARC form'. > 9) Change the 'IDreamBooksResults' system preference to 'Add'. >10) Search for something that will find "The Road To Character" > and something else in the OPAC. >11) Run your mouse over the title text in the search results. > -- Link will be to opac-MARCdetail.pl >12) Run your mouse over the cover image or lack thereof. > -- Link will be to opac-detail.pl > -- This will fail for both "The Road to Character" and the > non-"The Road to Character" entries. >13) Apply this patch >14) Refresh the OPAC page > -- Links under the cover images will be corrected. >15) In the staff client, change 'IDreamBooksReviews' to 'Add'. >16) Refresh the OPAC page > -- "The Road to Character" will be correct, but have a > '#idb_critic_reviews' appended. >17) run koha qa test tools >--- > .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 24 +++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 79ba0d5..5c2f739 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -22,6 +22,14 @@ > [% INCLUDE 'bodytag.inc' bodyid='results' bodyclass='scrollto' %] > [% INCLUDE 'masthead.inc' %] > >+[% IF BiblioDefaultViewmarc %] >+ [% SET OPACPage="opac-MARCdetail.pl" %] >+[% ELSIF BiblioDefaultViewisbd %] >+ [% SET OPACPage="opac-ISBDdetail.pl" %] >+[% ELSE %] >+ [% SET OPACPage="opac-detail.pl" %] >+[% END %] >+ > <div class="main"> > <ul class="breadcrumb"> > <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> >@@ -234,7 +242,7 @@ > [% # Cell 5: Search result details and controls %] > <td class="bibliocol"> > <div class="coverimages"> >- <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]"> >+ <a class="p1" href="/cgi-bin/koha/[% OPACPage %]?biblionumber=[% SEARCH_RESULT.biblionumber %]"> > [% IF ( OPACLocalCoverImages ) %] > <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.biblionumber %]" id="local-thumbnail[% loop.count %]"></span> > [% END %] >@@ -309,9 +317,9 @@ > [% IF ( IDreamBooksResults && SEARCH_RESULT.normalized_isbn ) %] > <div class="idbresult" style="display: none;"> > [% IF ( IDreamBooksReviews ) %] >- <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]#idb_critic_reviews"> >+ <a href="/cgi-bin/koha/[% OPACPage %]?biblionumber=[% SEARCH_RESULT.biblionumber %]#idb_critic_reviews"> > [% ELSE %] >- <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]"> >+ <a href="/cgi-bin/koha/[% OPACPage %]?biblionumber=[% SEARCH_RESULT.biblionumber %]"> > [% END %] > [% SEARCH_RESULT.normalized_isbn %]</a> > </div> >@@ -325,15 +333,7 @@ > [% IF ( OPACXSLTResultsDisplay ) %] > [% SEARCH_RESULT.XSLTResultsRecord %] > [% ELSE %] >- [% IF ( BiblioDefaultViewmarc ) %] >- <a class="title" href="/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber |url %]" title="View details for this title"> >- [% ELSE %] >- [% IF ( BiblioDefaultViewisbd ) %] >- <a class="title" href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber |url %]" title="View details for this title"> >- [% ELSE %] >- <a class="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber |url %]" title="View details for this title"> >- [% END %] >- [% END %] >+ <a class="title" href="/cgi-bin/koha/[% OPACPage %]?biblionumber=[% SEARCH_RESULT.biblionumber |url %]" title="View details for this title"> > > [% IF ( SEARCH_RESULT.title ) %] > [% SEARCH_RESULT.title |html %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14259
:
40851
|
44776
|
45342