Attachment 40857 Details for Bug 14445 – Bug 14445: Silences warns in letter.tt

[patch] Bug 14445: Silences warns in letter.tt

Bug-14445-Silences-warns-in-lettertt.patch (text/plain), 2.87 KB, created by Jonathan Druart on 2015-07-09 07:42:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-07-09 07:42:36 UTC

Size: 2.87 KB

patch

obsolete

>From c2a7aa110734e602e60daf2ccde5fac8f86ed994 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Wed, 1 Jul 2015 01:36:00 +0000
>Subject: [PATCH] Bug 14445: Silences warns in letter.tt
>
>When creating a new notice, warn is triggered "Argument "" isn't numeric in numeric gt (>) at line 400". Same warn is triggered when changing Koha module option to any other module.
>
>To test:
>1) Go to Tools, then Notices & Slips
>2) Click 'new notice'. Notice warn in intranet-error.log
>3) Change Koha module to another module. Notice warn is triggered for every change
>4) Apply patch and reload page
>5) Change Koha module to another module. Notice there are no longer warns
>6) Go back to Notices & Slips and click 'new notice' again. Notice there are no warns
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 6 +++---
> tools/letter.pl                                         | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index 06bf585..c20c6b7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -401,14 +401,14 @@ $(document).ready(function() {
>                 <li>
>                   <label for="SQLfieldname_[% letter.message_transport_type %]">Message body:</label>
>                   [% IF letter.message_transport_type == 'sms' %]
>-                    <span id="sms_counter">[% IF letter.content.length > 0 %][% letter.content.length %][% ELSE %]0[% END %]/160 characters</span>
>+                    <span id="sms_counter">[% IF letter.content && letter.content.length > 0 %][% letter.content.length %][% ELSE %]0[% END %]/160 characters</span>
>                   [% END %]
>                   <table>
>                     <tr>
>                       <td>
>                         <select name="SQLfieldname" id="SQLfieldname_[% letter.message_transport_type %]" multiple="multiple" size="9">
>-                          [% FOREACH SQLfieldnam IN SQLfieldname %]
>-                            <option value="[% SQLfieldnam.value %]">[% SQLfieldnam.text %]</option>
>+                          [% FOREACH SQLfieldname IN SQLfieldnames %]
>+                            <option value="[% SQLfieldname.value %]">[% SQLfieldname.text %]</option>
>                           [% END %]
>                         </select>
>                       </td>
>diff --git a/tools/letter.pl b/tools/letter.pl
>index 8ef07be..bb54d7e 100755
>--- a/tools/letter.pl
>+++ b/tools/letter.pl
>@@ -237,7 +237,7 @@ sub add_form {
>     $template->param(
>         module     => $module,
>         branchloop => _branchloop($branchcode),
>-        SQLfieldname => $field_selection,
>+        SQLfieldnames => $field_selection,
>     );
>     return;
> }
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14445: 40545 | 40743 | 40856 | 40857 | 40922 | 40923