Bugzilla – Attachment 40899 Details for
Bug 13517
Show waiting date on reserve/request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13517 [QA Followup] - Add unit tests
Bug-13517-QA-Followup---Add-unit-tests.patch (text/plain), 2.47 KB, created by
Jonathan Druart
on 2015-07-09 16:48:02 UTC
(
hide
)
Description:
Bug 13517 [QA Followup] - Add unit tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-07-09 16:48:02 UTC
Size:
2.47 KB
patch
obsolete
>From 830b2c4c483a1bb1520f4a0533ce208a8934630f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 25 Jun 2015 15:17:12 -0400 >Subject: [PATCH] Bug 13517 [QA Followup] - Add unit tests > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Hold.t | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Hold.t b/t/db_dependent/Hold.t >index ccd24cd..a91917c 100755 >--- a/t/db_dependent/Hold.t >+++ b/t/db_dependent/Hold.t >@@ -19,8 +19,9 @@ use Modern::Perl; > > use C4::Context; > use Koha::Database; >+use Koha::Borrowers; > >-use Test::More tests => 8; >+use Test::More tests => 16; > > use_ok('Koha::Hold'); > >@@ -30,13 +31,25 @@ $schema->storage->txn_begin(); > my $dbh = C4::Context->dbh; > $dbh->{RaiseError} = 1; > >-my $hold = Koha::Hold->new({ found => 'W', waitingdate => '2000-01-01'}); >+my $borrower = Koha::Borrowers->search()->next(); >+my $hold = Koha::Hold->new( >+ { >+ found => 'W', >+ waitingdate => '2000-01-01', >+ borrowernumber => $borrower->borrowernumber(), >+ } >+); >+my $hold_borrower = $hold->borrower(); >+ok( $hold_borrower, 'Got hold borrower' ); >+is( $hold_borrower->borrowernumber(), $borrower->borrowernumber(), 'Hold borrower matches correct borrower' ); > > C4::Context->set_preference( 'ReservesMaxPickUpDelay', '' ); > my $dt = $hold->waiting_expires_on(); > is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set"); > > is( $hold->is_waiting, 1, 'The hold is waiting' ); >+is( $hold->is_found, 1, 'The hold is found'); >+isnt( $hold->is_in_transit, 'The hold is not in transit' ); > > C4::Context->set_preference( 'ReservesMaxPickUpDelay', '5' ); > $dt = $hold->waiting_expires_on(); >@@ -46,11 +59,15 @@ $hold->found('T'); > $dt = $hold->waiting_expires_on(); > is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to 'T' )"); > isnt( $hold->is_waiting, 1, 'The hold is not waiting (T)' ); >+is( $hold->is_found, 1, 'The hold is found'); >+is( $hold->is_in_transit, 1, 'The hold is in transit' ); > > $hold->found(q{}); > $dt = $hold->waiting_expires_on(); > is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )"); > isnt( $hold->is_waiting, 1, 'The hold is not waiting (W)' ); >+is( $hold->is_found, 0, 'The hold is not found' ); >+isnt( $hold->is_in_transit, 'The hold is not in transit' ); > > $schema->storage->txn_rollback(); > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13517
:
34958
|
34959
|
35454
|
35834
|
35861
|
35862
|
35863
|
36983
|
36986
|
40025
|
40032
|
40036
|
40676
|
40677
|
40892
|
40893
|
40898
|
40899
|
40900
|
42604
|
42605
|
42606
|
43066
|
43067
|
43068