Attachment 40922 Details for Bug 14445 – [PASSED QA] Bug 14445: Silences warn in letter.pl

[patch] [PASSED QA] Bug 14445: Silences warn in letter.pl

PASSED-QA-Bug-14445-Silences-warn-in-letterpl.patch (text/plain), 1.38 KB, created by Kyle M Hall (khall) on 2015-07-10 14:30:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-07-10 14:30:07 UTC

Size: 1.38 KB

patch

obsolete

>From 816818b3e8f1aac7d597abc4117a94a00920b9d3 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Wed, 24 Jun 2015 01:15:32 +0000
>Subject: [PATCH] [PASSED QA] Bug 14445: Silences warn in letter.pl
>
>When changing Koha module to 'Circulation', there is a warn saying that $code is uninitialized. This patch sets $code to an empty string to silence the warn.
>
>To test:
>1) Go to Tools, the Notices & Slips
>2) Click 'new notice' (This will trigger warns, but ignore these as they will be corrected in the next patch)
>3) Change Koha module to 'Circulation'
>4) Notice warn about uninitialized $code variable
>5) Apply patch and reload page, change Koha module to 'Circulation'
>6) Notice page still works and warns are gone
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> tools/letter.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/tools/letter.pl b/tools/letter.pl
>index ca9f0ce..8ef07be 100755
>--- a/tools/letter.pl
>+++ b/tools/letter.pl
>@@ -227,7 +227,7 @@ sub add_form {
> 
>         }
> 
>-        if ( $module eq 'circulation' && $code eq "CHECKIN" ) {
>+        if ( $module eq 'circulation' and $code and $code eq "CHECKIN" ) {
>             push @{$field_selection}, add_fields('old_issues');
>         } else {
>             push @{$field_selection}, add_fields('issues');
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14445: 40545 | 40743 | 40856 | 40857 | 40922 | 40923