Attachment 40936 Details for Bug 14121 – [PASSED QA] Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t

[patch] [PASSED QA] Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t

PASSED-QA-Bug-14121-Silence-warnings-tdbdependentA.patch (text/plain), 2.21 KB, created by Kyle M Hall (khall) on 2015-07-10 15:46:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-07-10 15:46:44 UTC

Size: 2.21 KB

patch

obsolete

>From 492e7778beabec2545af79de1776d76de53a130c Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Wed, 27 May 2015 16:11:38 -0400
>Subject: [PATCH] [PASSED QA] Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t
>
>TEST PLAN
>---------
>1) $ prove t/db_dependent/Auth_with_cas.t
>   -- CGI security warning
>2) apply patch
>3) $ prove t/db_dependent/Auth_with_cas.t
>   -- no noise.
>4) koha qa test tools
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Not able to reproduce the error on my setup, but the code
>is a clear improvement over the previous version.
>---
> C4/Auth_with_cas.pm            |    9 +++++----
> t/db_dependent/Auth_with_cas.t |    1 +
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm
>index 2cccebe..1749333 100644
>--- a/C4/Auth_with_cas.pm
>+++ b/C4/Auth_with_cas.pm
>@@ -208,13 +208,14 @@ sub _url_with_get_params {
>                         C4::Context->preference('staffClientBaseURL');
> 
>     my $uri_params_part = '';
>-    foreach ( $query->url_param() ) {
>+    foreach my $param ( $query->url_param() ) {
>         # url_param() always returns parameters that were deleted by delete()
>         # This additional check ensure that parameter was not deleted.
>-        if ($query->param($_)) {
>+        my $uriPiece = $query->param($param);
>+        if ($uriPiece) {
>             $uri_params_part .= '&' if $uri_params_part;
>-            $uri_params_part .= $_ . '=';
>-            $uri_params_part .= URI::Escape::uri_escape( $query->param($_) );
>+            $uri_params_part .= $param . '=';
>+            $uri_params_part .= URI::Escape::uri_escape( $uriPiece );
>         }
>     }
>     $uri_base_part .= '?' if $uri_params_part;
>diff --git a/t/db_dependent/Auth_with_cas.t b/t/db_dependent/Auth_with_cas.t
>index b67ba1e..adea51b 100755
>--- a/t/db_dependent/Auth_with_cas.t
>+++ b/t/db_dependent/Auth_with_cas.t
>@@ -38,6 +38,7 @@ my $dbh = C4::Context->dbh;
> $dbh->{ AutoCommit } = 0;
> $dbh->{ RaiseError } = 1;
> 
>+C4::Context->disable_syspref_cache();
> C4::Context->set_preference('OPACBaseURL','http://localhost');
> C4::Context->set_preference('staffClientBaseURL','localhost:8080');
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14121: 38763 | 39621 | 40696 | 40936