Bugzilla – Attachment 40972 Details for
Bug 11700
C4::AuthoritiesMarc::merge enhancements/fixes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11700: Add description to unit tests
Bug-11700-Add-description-to-unit-tests.patch (text/plain), 1.68 KB, created by
Julian Maurice
on 2015-07-13 14:10:26 UTC
(
hide
)
Description:
Bug 11700: Add description to unit tests
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2015-07-13 14:10:26 UTC
Size:
1.68 KB
patch
obsolete
>From 9cb39f09b1824b59fd24f08a0572aedb31db0c6e Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 13 Jul 2015 16:04:14 +0200 >Subject: [PATCH] Bug 11700: Add description to unit tests > >--- > t/db_dependent/AuthoritiesMarc.t | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/AuthoritiesMarc.t b/t/db_dependent/AuthoritiesMarc.t >index 875e4f2..28e3c18 100755 >--- a/t/db_dependent/AuthoritiesMarc.t >+++ b/t/db_dependent/AuthoritiesMarc.t >@@ -251,16 +251,16 @@ $zoom_record->mock('raw', sub { > > my @biblios = C4::AuthoritiesMarc::merge($authid2, undef, $authid1, undef); > >-is_deeply(\@biblios, [$biblionumber2]); >+is_deeply(\@biblios, [$biblionumber2], 'merge() modified the expected biblio'); > $biblio1 = GetMarcBiblio($biblionumber1); >-is($biblio1->subfield('609', '9'), $authid1); >-is($biblio1->subfield('609', 'a'), 'George Orwell'); >+is($biblio1->subfield('609', '9'), $authid1, 'field 609 of 1st biblio is unchanged'); >+is($biblio1->subfield('609', 'a'), 'George Orwell', 'field 609 of 1st biblio is unchanged'); > $biblio2 = GetMarcBiblio($biblionumber2); >-is($biblio2->subfield('609', '9'), $authid1); >-is($biblio2->subfield('609', 'a'), 'George Orwell'); >+is($biblio2->subfield('609', '9'), $authid1, 'field 609 of 2nd biblio has been modified'); >+is($biblio2->subfield('609', 'a'), 'George Orwell', 'field 609 of 2nd biblio has been modified'); > >-ok(defined(GetAuthority($authid1))); >-ok(!defined(GetAuthority($authid2))); >+ok(defined(GetAuthority($authid1)), '1st authority still exists'); >+ok(!defined(GetAuthority($authid2)), '2nd authority was deleted'); > # End testing C4::AuthoritiesMarc::merge > > $dbh->rollback; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11700
:
25086
|
25413
|
25414
|
25426
|
27970
|
27971
|
27972
|
27973
|
28176
|
28177
|
35107
|
39264
|
39265
|
39266
|
39267
|
39268
|
39269
|
40968
|
40969
|
40970
|
40971
|
40972
|
45048
|
45049
|
45050
|
45051
|
45052
|
45053
|
46397
|
46398
|
46399
|
46400
|
46401
|
46402
|
56469
|
56470
|
56471
|
56472
|
56473
|
56474