Attachment 40995 Details for Bug 14528 – Bug 14528: Inconsistency in permissions check when listing shelves

[patch] Bug 14528: Inconsistency in permissions check when listing shelves

Bug-14528-Inconsistency-in-permissions-check-when-.patch (text/plain), 1.75 KB, created by Jonathan Druart on 2015-07-14 15:48:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-07-14 15:48:44 UTC

Size: 1.75 KB

patch

obsolete

>From 4bbb707db2e62e0aa62be3c87654f59b7290dd75 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 14 Jul 2015 16:44:37 +0100
>Subject: [PATCH] Bug 14528: Inconsistency in permissions check when listing
> shelves
>
>The svc script needed borrowers when the shelves.pl needed catalogue.
>There is no sense to have different permissions here.
>
>Test plan:
>1/ Remove the borrowers permission to a user
>2/ Use this user to log in
>3/ Go on the shelf list
>4/ Without this patch, you should get an endless "Processing..." which
>is fixed if you apply it.
>---
> misc/translator/po/es-ES-staff-prog.po | 2 +-
> svc/virtualshelves/search              | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/misc/translator/po/es-ES-staff-prog.po b/misc/translator/po/es-ES-staff-prog.po
>index 4485a86..9772369 100644
>--- a/misc/translator/po/es-ES-staff-prog.po
>+++ b/misc/translator/po/es-ES-staff-prog.po
>@@ -19349,7 +19349,7 @@ msgstr "Ed Summers (cÃ³digo y paquetes Perl tales como MARC::Record)"
> #: intranet-tmpl/prog/en/modules/rotating_collections/rotatingCollections.tt:53
> #, c-format
> msgid "Edit"
>-msgstr "Editar"
>+msgstr "Edit'ar"
> 
> #: intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc:35
> #: intranet-tmpl/prog/en/includes/cat-toolbar.inc:164
>diff --git a/svc/virtualshelves/search b/svc/virtualshelves/search
>index ef1448c..5e991fc 100755
>--- a/svc/virtualshelves/search
>+++ b/svc/virtualshelves/search
>@@ -17,7 +17,7 @@ my ($template, $user, $cookie) = get_template_and_user({
>     query           => $input,
>     type            => "intranet",
>     authnotrequired => 0,
>-    flagsrequired   => { borrowers => 1 }
>+    flagsrequired   => { catalogue => 1 }
> });
> 
> my $shelfname = $input->param('shelfname');
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14528: 40995 | 40996 | 41090 | 43083