Attachment 41031 Details for Bug 14541 – Bug 14541 - Tax rate should not be forced to an arbitrary precision

[patch] Bug 14541 - Tax rate should not be forced to an arbitrary precision

Bug-14541---Tax-rate-should-not-be-forced-to-an-ar.patch (text/plain), 2.08 KB, created by Kyle M Hall (khall) on 2015-07-16 15:17:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-07-16 15:17:48 UTC

Size: 2.08 KB

patch

obsolete

>From 981e09a0bb68f9c762782d7d11f1b0430bfb7650 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 16 Jul 2015 11:15:41 -0400
>Subject: [PATCH] Bug 14541 - Tax rate should not be forced to an arbitrary precision
>
>The following is an example gstrate for a real library
>0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625
>
>Note the .08625 and .0863
>
>Both of those rates show up as 8.6% for the order line editor (
>        acqui/neworderempty.pl ).
>
>There is no reason to force these numbers to be rounded and in fact
>makes the label not match the value!
>
>Test Plan:
>1) Set you gstrate pref to 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625
>2) Edit an order line
>3) Note that the tax rate pulldown lists 8.6% twice
>4) Apply this patch
>5) Refesh the page
>6) Note the pulldown now lists the actual tax rate values
>---
> .../prog/en/modules/acqui/neworderempty.tt         |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index b0cc08c..5b5a075 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -558,9 +558,9 @@ $(document).ready(function()
>                         <select name="gstrate" id="gstrate" onchange="updateCosts();">
>                         [% FOREACH gst IN gst_values %]
>                           [% IF ( gst.option == gstrate ) %]
>-                            <option value="[% gst.option %]" selected="selected">[% gst.option * 100 | format("%.1f") %]%</option>
>+                            <option value="[% gst.option %]" selected="selected">[% gst.option * 100 %]%</option>
>                           [% ELSE %]
>-                            <option value="[% gst.option %]">[% gst.option * 100 | format("%.1f") %]%</option>
>+                            <option value="[% gst.option %]">[% gst.option * 100 %]%</option>
>                           [% END %]
>                         [% END %]
>                         </select>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14541: 41031 | 41075 | 57363 | 57872 | 58050 | 58051