Bugzilla – Attachment 41033 Details for
Bug 14543
Order lines updated that have a tax rate not in gist will have tax rate set to 0!
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14543 - Order lines updated that have a tax rate not in gist will have tax rate set to 0!
Bug-14543---Order-lines-updated-that-have-a-tax-ra.patch (text/plain), 2.88 KB, created by
Kyle M Hall (khall)
on 2015-07-16 16:16:17 UTC
(
hide
)
Description:
Bug 14543 - Order lines updated that have a tax rate not in gist will have tax rate set to 0!
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-07-16 16:16:17 UTC
Size:
2.88 KB
patch
obsolete
>From 712c24eca8244595237ead320c60f7172b36c51b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 16 Jul 2015 12:14:42 -0400 >Subject: [PATCH] Bug 14543 - Order lines updated that have a tax rate not in gist will have tax rate set to 0! > >If the tax rate for a given order line has been removed from the system >preference gist, that tax rate will show in the pulldown as 0. If a >librarian then saves the order line the original tax rate will be >overwritten with 0%! > >Test Plan: >1) Find an order line >2) Remove the tax rate set for that order line from the syspref gist >3) Edit the order line >4) Note the tax rate is 0 >5) Apply this patch >6) Edit the order line >7) Note the tax rate now displays with a warning >--- > .../prog/en/modules/acqui/neworderempty.tt | 23 +++++++++++++------ > 1 files changed, 16 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 5b5a075..df249f2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -556,14 +556,23 @@ $(document).ready(function() > [% ELSE %] > <label for="gstrate">Tax rate: </label> > <select name="gstrate" id="gstrate" onchange="updateCosts();"> >- [% FOREACH gst IN gst_values %] >- [% IF ( gst.option == gstrate ) %] >- <option value="[% gst.option %]" selected="selected">[% gst.option * 100 %]%</option> >- [% ELSE %] >- <option value="[% gst.option %]">[% gst.option * 100 %]%</option> >- [% END %] >- [% END %] >+ [% SET gst_found = 0 %] >+ >+ [% FOREACH gst IN gst_values %] >+ [% IF ( gst.option == gstrate ) %] >+ <option value="[% gst.option %]" selected="selected">[% gst.option * 100 %]%</option> >+ [% SET gst_found = 1 %] >+ [% ELSE %] >+ <option value="[% gst.option %]">[% gst.option * 100 %]%</option> >+ [% END %] >+ [% END %] >+ >+ [% IF !gst_found %] >+ <option value="[% gstrate %]" selected="selected">[% gstrate * 100 %]%</option> >+ [% END %] > </select> >+ >+ [% IF !gst_found %]<span class="required">Tax rate not defined in system preference gist!</span>[% END %] > [% END %] > [% ELSE %] > <input type="hidden" name="gstrate" value="0" /> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14543
:
41033
|
95942
|
95943
|
105181
|
105404
|
105629
|
105630