Bugzilla – Attachment 41094 Details for
Bug 14534
Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14534: Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber
Bug-14534-Stop-overduenoticespl-from-issuing-the-w.patch (text/plain), 1.22 KB, created by
Chris Cormack
on 2015-07-19 21:38:50 UTC
(
hide
)
Description:
Bug 14534: Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2015-07-19 21:38:50 UTC
Size:
1.22 KB
patch
obsolete
>From be94d59902e3fc6e286eec2e4119509c831fe89c Mon Sep 17 00:00:00 2001 >From: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> >Date: Wed, 15 Jul 2015 08:35:13 +0200 >Subject: [PATCH] Bug 14534: Stop overdue_notices.pl from issuing the warning: > Use of uninitialized value $borrowernumber > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >To test: > >1/ Run the overdue_notices.pl script (don't do this on production >obviously :)) >2/ Notice the warns >3/ Apply patch >4/ Run again >5/ Notice no warns, but notices are still generated ok >--- > misc/cronjobs/overdue_notices.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index f87f254..482be02 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -556,7 +556,7 @@ END_SQL > next; > } > } >- if ($borrowernumber eq $data->{'borrowernumber'}){ >+ if (defined $borrowernumber && $borrowernumber eq $data->{'borrowernumber'}){ > # we have already dealt with this borrower > $verbose and warn "already dealt with this borrower $borrowernumber"; > next; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14534
:
41005
|
41094
|
41374