Bugzilla – Attachment 41111 Details for
Bug 14167
Add Koha::Logger based on Log4perl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14167: (QA followup) new entries in koha-conf.xml should be tested in about.pl
Bug-14167-QA-followup-new-entries-in-koha-confxml-.patch (text/plain), 1.80 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-07-21 14:55:41 UTC
(
hide
)
Description:
Bug 14167: (QA followup) new entries in koha-conf.xml should be tested in about.pl
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-07-21 14:55:41 UTC
Size:
1.80 KB
patch
obsolete
>From 2331a21cc8901ee69a57a7ade472b4b21c29e5b6 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >Date: Tue, 21 Jul 2015 11:54:17 -0300 >Subject: [PATCH] Bug 14167: (QA followup) new entries in koha-conf.xml should > be tested in about.pl > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >--- > about.pl | 6 ++++++ > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 7 +++++++ > 2 files changed, 13 insertions(+) > >diff --git a/about.pl b/about.pl >index 4e06ae5..847dc2b 100755 >--- a/about.pl >+++ b/about.pl >@@ -151,6 +151,12 @@ if ( (C4::Context->config('zebra_auth_index_mode') eq 'grs1') && ($context->{'se > }; > } > >+if ( ! defined C4::Context->config('log4perl_conf') ) { >+ push @xml_config_warnings, { >+ error => 'log4perl_entry_missing' >+ } >+} >+ > # Test QueryParser configuration sanity > if ( C4::Context->preference( 'UseQueryParser' ) ) { > # Get the QueryParser configuration file name >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 782e61d..dd2bf4c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -229,6 +229,13 @@ > to legacy facet calculation. > </td> > </tr> >+ [% ELSIF config_entry.error == 'log4perl_entry_missing' %] >+ <tr> >+ <th scope="row"><b>Warning</b></th> >+ <td>You are missing the <log4perl_conf> entry in your koha-conf.xml file. Please >+ add it, pointing to the log4perl.conf file for your Koha instance. >+ </td> >+ </tr> > [% END %] > [% END %] > </table> >-- >2.4.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14167
:
38953
|
38954
|
38980
|
38981
|
38993
|
39103
|
39180
|
39886
|
39887
|
39888
|
39889
|
39890
|
39891
|
39892
|
39893
|
39894
|
39895
|
40200
|
40652
|
40653
|
40657
|
40658
|
40659
|
40660
|
40661
|
40662
|
40663
|
40664
|
41109
| 41111 |
41145
|
41146