Bugzilla – Attachment 41171 Details for
Bug 8684
Duplicate check for creating items on order broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8684: Fix duplicate check on creating items in the acquisition module
PASSED-QA-Bug-8684-Fix-duplicate-check-on-creating.patch (text/plain), 1.92 KB, created by
Kyle M Hall (khall)
on 2015-07-24 15:46:29 UTC
(
hide
)
Description:
[PASSED QA] Bug 8684: Fix duplicate check on creating items in the acquisition module
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-07-24 15:46:29 UTC
Size:
1.92 KB
patch
obsolete
>From 5c47ac30cedcdaee092c4c4466b5116cac4fb8ab Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 7 Apr 2015 14:14:18 +0200 >Subject: [PATCH] [PASSED QA] Bug 8684: Fix duplicate check on creating items in the acquisition module > >The script acqui/check_uniqueness.pl has been introduced by bug 7178. >But bug 11425 added a call to a new subroutine SearchItemsByField in >order to refactore some code. This subroutine calls SearchItems with an >arrayref, which is not what SearchItems is expecting. >This broke the duplicate check done on creating items in the acquisition >module. > >To reproduce the issue: >1/ Fill the pref UniqueItemFields with "barcode" and AcqCreateItem with >"placing an order" >2/ Create a new basket >3/ Create a new order >4/ Close the basket >5/ Receive items and set barcode with one already in your DB >6/ Save >7/ Nothing happen on the interface, but an error should have been added >in your Koha log file: > Can't use an undefined value as an ARRAY reference at > /home/koha/src/acqui/check_uniqueness.pl line 48. > >Test plan: >1/ Repeat steps 1-6 >2/ You should see a warning on the interface > >Note that this should also happen with AcqCreateItem set to "creating an >order". > >Works well, no errors. > >Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Items.pm | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 55bb4bd..0e639dc 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2608,10 +2608,10 @@ For instance you can search all items with a specific stocknumber like this: > sub SearchItemsByField { > my ($field, $value) = @_; > >- my $filters = [ { >- field => $field, >- query => $value, >- } ]; >+ my $filters = { >+ field => $field, >+ query => $value, >+ }; > > my ($results) = SearchItems($filters); > return $results; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8684
:
37545
|
37712
|
40790
|
40791
| 41171 |
41172