Bugzilla – Attachment 41214 Details for
Bug 10961
Error in GetMarcBiblio can cause severe data loss
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10961: Error in GetMarcBiblio can cause severe data loss
PASSED-QA-Bug-10961-Error-in-GetMarcBiblio-can-cau.patch (text/plain), 2.23 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-07-28 13:10:17 UTC
(
hide
)
Description:
[PASSED QA] Bug 10961: Error in GetMarcBiblio can cause severe data loss
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-07-28 13:10:17 UTC
Size:
2.23 KB
patch
obsolete
>From dc832a4f3c02877d9a92e80d21d8f3b5330809ba Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 27 Sep 2013 12:53:39 -0400 >Subject: [PATCH] [PASSED QA] Bug 10961: Error in GetMarcBiblio can cause > severe data loss > >A bug in GetMarcBiblio can cause severe data loss if your database has >records where the biblionumber and biblioitemnumber do not match and the >script misc/batchRebuildBiblioTables.pl is run. > >The Biblio::GetMarcBiblio makes a kall to >C4::Biblio::_koha_marc_update_bib_ids which passes the biblionumber as >both the biblionumber *and the biblioitemnumber*. > >Thus, if your biblio and biblioitem numbers are not always equal, you >will end up with a record where the biblioitemnumber is incorrect in the >record! > >This is usually not a severe issue, but since batchRebuildBiblioTables >uses that record to update the database tables, it ends up updating the >wrong biblioitem row! > >NOTE: What a horrible, horrible typo that was. Tested this with the > second patch. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >--- > C4/Biblio.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 7e0aa1f..533932b 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1268,7 +1268,7 @@ sub GetMarcBiblio { > } > > my $dbh = C4::Context->dbh; >- my $sth = $dbh->prepare("SELECT marcxml FROM biblioitems WHERE biblionumber=? "); >+ my $sth = $dbh->prepare("SELECT * FROM biblioitems WHERE biblionumber=? "); > $sth->execute($biblionumber); > my $row = $sth->fetchrow_hashref; > my $marcxml = StripNonXmlChars( $row->{'marcxml'} ); >@@ -1280,8 +1280,8 @@ sub GetMarcBiblio { > if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; } > return unless $record; > >- C4::Biblio::_koha_marc_update_bib_ids($record, '', $biblionumber, $biblionumber); >- C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems); >+ C4::Biblio::_koha_marc_update_bib_ids($record, '', $biblionumber, $row->{biblioitemnumber}); >+ C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems); > > return $record; > } else { >-- >2.5.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10961
:
21520
|
41130
|
41182
|
41183
| 41214 |
41215