Bugzilla – Attachment 41393 Details for
Bug 14607
Make Baker & Taylor cover images accessible by UPC as well as ISBN
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN
Bug-14607-Baker--Taylor-cover-images-should-be-acc.patch (text/plain), 15.02 KB, created by
Jesse Weaver
on 2015-08-05 22:21:23 UTC
(
hide
)
Description:
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN
Filename:
MIME Type:
Creator:
Jesse Weaver
Created:
2015-08-05 22:21:23 UTC
Size:
15.02 KB
patch
obsolete
>From 5902f08f9c803a104c2c9d01076c038f464ae56f Mon Sep 17 00:00:00 2001 >From: Jesse Weaver <pianohacker@gmail.com> >Date: Fri, 24 Jul 2015 14:33:56 -0600 >Subject: [PATCH] Bug 14607: Baker & Taylor cover images should be accessible > by UPC as well as ISBN > >Test plan (requires Baker and Taylor cover images to be set up and enabled): > 1. Create a record with an ISBN that does not have a cover and a UPC > that does. 141985934X/085391174929 is one set that works well. > 2. Verify that the record shows up as "No image available" in the > following OPAC locations: shelf browser, reviews, lists, search and > reading record. This will require adding reviews/checkouts/etc. for > the record in question. > 3. Apply patch. > 4. Check the locations again, and verify that the record now has a > valid cover image. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 5 +++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 9 +++++---- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt | 3 ++- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 12 +++++++----- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 5 +++-- > .../opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt | 3 ++- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt | 5 +++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 5 +++-- > 8 files changed, 28 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 255fac1..b0b2970 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -58,8 +58,9 @@ > <div title="[% item.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail-preview-[% coce_id %]"></div> > [% END %] > [% IF ( BakerTaylorEnabled ) %] >- [% IF ( item.browser_normalized_isbn ) %] >- <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% item.browser_normalized_isbn %]" /> >+ [% bt_id = ( item.browser_normalized_upc || item.browser_normalized_upc ) %] >+ [% IF ( bt_id ) %] >+ <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 6799e23..d1d89fa 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -88,15 +88,16 @@ > [% IF OpenLibraryCovers %] > <div title="[% biblionumber |url %]" class="[% normalized_isbn %]" id="openlibrary-thumbnail-preview"></div> > [% END %] >- [% IF ( BakerTaylorEnabled && normalized_isbn ) %] >+ [% bt_id = ( normalized_upc || normalized_isbn ) %] >+ [% IF ( BakerTaylorEnabled && bt_id ) %] > [% IF BakerTaylorBookstoreURL %] > [% IF ( OPACurlOpenInNewWindow ) %] >- <a href="https://[% BakerTaylorBookstoreURL |html %][% normalized_isbn %]" target="_blank"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% normalized_isbn %]" /></a> >+ <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]" target="_blank"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% ELSE %] >- <a href="https://[% BakerTaylorBookstoreURL |html %][% normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% normalized_isbn %]" /></a> >+ <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% END %] > [% ELSE %] >- <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% normalized_isbn %]" /> >+ <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /> > [% END %] > [% END %] > </div><!-- / #bookcover --> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >index 34cfcc5..e1a9efe 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >@@ -43,7 +43,8 @@ > <img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc %]&oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" /> > [% END %][% END %][% END %] > >-[% IF ( BakerTaylorEnabled ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<a href="https://[% BakerTaylorBookstoreURL |html %][% SEARCH_RESULT.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" /></a>[% END %][% END %] >+[% bt_id = ( SEARCH_RESULT.normalized_upc || SEARCH_RESULT.normalized_isbn ) %] >+[% IF ( BakerTaylorEnabled ) %][% IF bt_id %]<a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a>[% END %][% END %] > <p>[% IF ( SEARCH_RESULT.author ) %]By [% SEARCH_RESULT.author |html %]. [% END %] > [% IF ( SEARCH_RESULT.place ) %][% SEARCH_RESULT.place |html %] [% END %][% IF ( SEARCH_RESULT.publishercode ) %][% SEARCH_RESULT.publishercode |html %][% END %][% IF ( SEARCH_RESULT.publicationyear ) %] [% SEARCH_RESULT.publicationyear |html %] > [% ELSE %][% IF ( SEARCH_RESULT.copyrightdate ) %] [% SEARCH_RESULT.copyrightdate |html %][% END %][% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index da1d62d..60ecab1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -288,8 +288,9 @@ > [% END %] > > [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %] >- [% IF ( SEARCH_RESULT.normalized_isbn ) %] >- <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" /> >+ [% bt_id = ( SEARCH_RESULT.normalized_upc || SEARCH_RESULT.normalized_isbn ) %] >+ [% IF ( bt_id ) %] >+ <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -297,9 +298,10 @@ > </a> > > [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %] >- [% IF ( SEARCH_RESULT.normalized_isbn ) %] >- <a href="https://[% BakerTaylorBookstoreURL |html %][% SEARCH_RESULT.normalized_isbn %]"> >- <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" /> >+ [% bt_id = ( SEARCH_RESULT.normalized_upc || SEARCH_RESULT.normalized_isbn ) %] >+ [% IF ( bt_id ) %] >+ <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"> >+ <img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /> > </a> > [% ELSE %] > <span class="no-image">No cover image available</span> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 3478866..1d72ba8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -333,8 +333,9 @@ > > </a> <!-- / .p1 --> > [% IF ( BakerTaylorEnabled ) %] >- [% IF ( itemsloo.normalized_isbn ) %] >- <a href="https://[% BakerTaylorBookstoreURL |html %][% itemsloo.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% itemsloo.normalized_isbn %]" /></a> >+ [% bt_id = ( itemsloo.normalized_upc || itemsloo.normalized_isbn ) %] >+ [% IF ( bt_id ) %] >+ <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt >index b354419..c6d858d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt >@@ -18,7 +18,8 @@ > <img src="http://www.syndetics.com/index.aspx?isbn=[% review.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% review.normalized_upc %]&oclc=[% review.normalized_oclc %]" alt="" /> > [% END %][% END %][% END %][% END %] > >-[% IF ( BakerTaylorEnabled ) %][% IF ( review.normalized_isbn ) %]<a href="https://[% BakerTaylorBookstoreURL |html %][% review.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% review.normalized_isbn %]" /></a>[% END %][% END %] >+[% bt_id = ( review.normalized_upc || review.normalized_isbn ) %] >+[% IF ( BakerTaylorEnabled && bt_id ) %]<a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a>[% END %] > [% IF ( review.author ) %]<p>By [% review.author |html %].</p> [% END %] > <p>[% IF ( review.place ) %][% review.place |html %] [% END %][% IF ( review.publishercode ) %][% review.publishercode |html %][% END %][% IF ( review.publicationyear ) %] [% review.publicationyear |html %] > [% ELSE %][% IF ( review.copyrightdate ) %] [% review.copyrightdate |html %][% END %][% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >index 6fca7ec..687a671 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >@@ -137,9 +137,10 @@ > [% END %] > [% END %] > </a> >+ [% bt_id = ( review.normalized_upc || review.normalized_isbn ) %] > [% IF ( BakerTaylorEnabled ) %] >- [% IF ( review.normalized_isbn ) %] >- <a href="https://[% review.BakerTaylorBookstoreURL |html %][% review.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% review.BakerTaylorImageURL |html %][% review.normalized_isbn %]" /></a> >+ [% IF ( bt_id ) %] >+ <a href="https://[% review.BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% review.BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index b5bc8d2..b7f443b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -166,8 +166,9 @@ > [% END %] > > [% IF ( BakerTaylorEnabled ) %] >- [% IF ( ISSUE.normalized_isbn ) %] >- <a href="https://[% BakerTaylorBookstoreURL |html %][% ISSUE.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% ISSUE.normalized_isbn %]" /></a> >+ [% bt_id = ( ISSUE.normalized_upc || ISSUE.normalized_isbn ) %] >+ [% IF ( bt_id ) %] >+ <a href="https://[% BakerTaylorBookstoreURL |html %][% bt_id %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% bt_id %]" /></a> > [% ELSE %] > <span class="no-image">No cover image available</span><!-- BakerTaylor needs normalized_isbn! --> > [% END %] >-- >2.4.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14607
:
41393
|
41633
|
42253
|
42547
|
43018
|
43019
|
43157
|
43158
|
43159