Bugzilla – Attachment 41486 Details for
Bug 13791
Plack - Out of the box support on packages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13791: make koha-list aware of plack
Bug-13791-make-koha-list-aware-of-plack.patch (text/plain), 3.38 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-08-13 18:29:42 UTC
(
hide
)
Description:
Bug 13791: make koha-list aware of plack
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-08-13 18:29:42 UTC
Size:
3.38 KB
patch
obsolete
>From 6040ac6ddf356202b3c5a9580322cc5acae84813 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 13 Aug 2015 14:49:01 -0300 >Subject: [PATCH] Bug 13791: make koha-list aware of plack > >This patch adds the --plack and --noplack option switches to koha-list >for filtering instances to be listed. > >This is particularly important for init scripts and cronjobs. > >To test: >- Play with koha-list --plack and koha-plack --enable/--disable and verify that >koha-list returns the expected results. >--- > debian/scripts/koha-list | 45 ++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 42 insertions(+), 3 deletions(-) > >diff --git a/debian/scripts/koha-list b/debian/scripts/koha-list >index 848494b..8286fc5 100755 >--- a/debian/scripts/koha-list >+++ b/debian/scripts/koha-list >@@ -37,20 +37,23 @@ show_instances() > case $show in > "all") > if instance_filter_email $instance $show_email && \ >- instance_filter_sip $instance $show_sip; then >+ instance_filter_plack $instance $show_plack && \ >+ instance_filter_sip $instance $show_sip; then > echo $instance > fi ;; > "enabled") > if is_enabled $instance; then > if instance_filter_email $instance $show_email && \ >- instance_filter_sip $instance $show_sip; then >+ instance_filter_plack $instance $show_plack && \ >+ instance_filter_sip $instance $show_sip; then > echo $instance > fi > fi ;; > "disabled") > if ! is_enabled $instance; then > if instance_filter_email $instance $show_email && \ >- instance_filter_sip $instance $show_sip; then >+ instance_filter_plack $instance $show_plack && \ >+ instance_filter_sip $instance $show_sip; then > echo $instance > fi > fi ;; >@@ -81,6 +84,28 @@ instance_filter_sip() > return 1 > } > >+instance_filter_plack() >+{ >+ local instancename=$1 >+ local show_plack=$2; >+ >+ case $show_plack in >+ "all") >+ return 0 ;; >+ "enabled") >+ if is_plack_enabled $instancename; then >+ return 0 >+ fi ;; >+ "disabled") >+ if ! is_plack_enabled $instancename; then >+ return 0 >+ fi ;; >+ esac >+ >+ # Didn't match any criteria >+ return 1 >+} >+ > instance_filter_email() > { > local instancename=$1 >@@ -125,6 +150,17 @@ set_show_email() > fi > } > >+set_show_plack() >+{ >+ local plack_param=$1 >+ >+ if [ "$show_plack" = "all" ]; then >+ show_plack=$plack_param >+ else >+ die "Error: --plack and --noplack are mutually exclusive." >+ fi >+} >+ > set_show_sip() > { > local sip_param=$1 >@@ -162,6 +198,7 @@ EOH > show="all" > show_email="all" > show_sip="all" >+show_plack="all" > > args=$(getopt -l help,enabled,disabled,email,noemail,sip,nosip -o h -n $0 -- "$@") > set -- $args >@@ -174,6 +211,8 @@ do > --noemail) set_show_email "disabled" ;; > --sip) set_show_sip "enabled" ;; > --nosip) set_show_sip "disabled" ;; >+ --plack) set_show_plack "enabled" ;; >+ --noplack) set_show_plack "disabled" ;; > --enabled) set_show "enabled" ;; > --disabled) set_show "disabled" ;; > *) break;; >-- >2.5.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13791
:
41481
|
41482
|
41483
|
41484
|
41485
|
41486
|
41503
|
41504
|
41505
|
41506
|
41507
|
41508
|
41509
|
41510
|
41511
|
41512
|
41513
|
41563
|
41564
|
41565
|
41566
|
41567
|
41568
|
41571
|
41572
|
41573
|
41574
|
41575
|
41576
|
41748
|
41749
|
41750
|
41751
|
41752
|
41753
|
41866
|
42038