Bugzilla – Attachment 41569 Details for
Bug 14337
AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14337 [QA Followup] - Add unit test
Bug-14337-QA-Followup---Add-unit-test.patch (text/plain), 1.54 KB, created by
Kyle M Hall (khall)
on 2015-08-17 16:53:24 UTC
(
hide
)
Description:
Bug 14337 [QA Followup] - Add unit test
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-08-17 16:53:24 UTC
Size:
1.54 KB
patch
obsolete
>From fc46f27a580c1edcba5cf478120d4a2c8ed194d8 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 17 Aug 2015 12:52:55 -0400 >Subject: [PATCH] Bug 14337 [QA Followup] - Add unit test > >--- > t/db_dependent/Circulation.t | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 30a5fe7..1381206 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -27,7 +27,7 @@ use C4::Overdues qw(UpdateFine); > use Koha::DateUtils; > use Koha::Database; > >-use Test::More tests => 61; >+use Test::More tests => 62; > > BEGIN { > use_ok('C4::Circulation'); >@@ -301,6 +301,11 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2); > is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds'); > >+ C4::Context->dbh->do("UPDATE items SET notforloan = 1 WHERE itemnumber = $itemnumber3"); >+ ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber); >+ is( $renewokay, 0, 'Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability'); >+ C4::Context->dbh->do("UPDATE items SET notforloan = 0 WHERE itemnumber = $itemnumber3"); >+ > # Now let's add an item level hold, we should no longer be able to renew the item > my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create( > { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14337
:
39898
|
41262
|
41263
|
41569
|
41708
|
41709
|
41787
|
41788
|
41904
|
41905
|
41906
|
41907
|
50840
|
50841