Bugzilla – Attachment 41608 Details for
Bug 12933
Add ability to print overdue slip from staff intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter
Bug-12933-QA-Followup---Rename-parseletter-to-pars.patch (text/plain), 2.59 KB, created by
Kyle M Hall (khall)
on 2015-08-18 15:07:48 UTC
(
hide
)
Description:
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-08-18 15:07:48 UTC
Size:
2.59 KB
patch
obsolete
>From 240937cbdc1a1a951337183a7e4db722b1eb0fd4 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 1 Jan 2015 18:48:03 -0500 >Subject: [PATCH] Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter > >--- > C4/Overdues.pm | 6 +++--- > members/print_overdues.pl | 4 ++-- > misc/cronjobs/overdue_notices.pl | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 14cba96..fa9e102 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -55,7 +55,7 @@ BEGIN { > &RemoveNotifyLine > &AddNotifyLine > &GetOverdueMessageTransportTypes >- &parse_letter >+ &parse_overdues_letter > ); > # subs to remove > push @EXPORT, qw( >@@ -952,7 +952,7 @@ sub GetOverdueMessageTransportTypes { > return \@mtts; > } > >-=head2 parse_letter >+=head2 parse_overdues_letter > > parses the letter template, replacing the placeholders with data > specific to this patron, biblio, or item for overdues >@@ -968,7 +968,7 @@ substituted keys and values. > > =cut > >-sub parse_letter { >+sub parse_overdues_letter { > my $params = shift; > foreach my $required (qw( letter_code borrowernumber )) { > return unless ( exists $params->{$required} && $params->{$required} ); >diff --git a/members/print_overdues.pl b/members/print_overdues.pl >index 3cc204b..526f615 100755 >--- a/members/print_overdues.pl >+++ b/members/print_overdues.pl >@@ -25,7 +25,7 @@ use C4::Context; > use C4::Auth; > use C4::Output; > use C4::Members qw(GetOverdues); >-use C4::Overdues qw(parse_letter); >+use C4::Overdues qw(parse_overdues_letter); > > my $input = new CGI; > >@@ -47,7 +47,7 @@ my $branchcode = C4::Context->userenv->{'branch'}; > > my $overdues = GetOverdues($borrowernumber); > >-my $letter = parse_letter( >+my $letter = parse_overdues_letter( > { > letter_code => 'OVERDUES_SLIP', > borrowernumber => $borrowernumber, >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index b9c0767..2f9fa68 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -672,7 +672,7 @@ END_SQL > my $print_sent = 0; # A print notice is not yet sent for this patron > for my $mtt ( @message_transport_types ) { > >- my $letter = parse_letter( >+ my $letter = parse_overdues_letter( > { letter_code => $overdue_rules->{"letter$i"}, > borrowernumber => $borrowernumber, > branchcode => $branchcode, >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12933
:
31638
|
31667
|
34456
|
34457
|
34467
|
34468
|
34469
|
34470
|
34471
|
34474
|
34475
|
34884
|
34885
|
34886
|
34887
|
34888
|
34889
|
35533
|
35534
|
35535
|
35536
|
35537
|
35538
|
35918
|
41606
|
41607
|
41608
|
41609
|
41610
|
41611
|
43514
|
43515
|
43516
|
43517
|
43518
|
43519
|
43520
|
43521
|
43522
|
43523
|
43904
|
43905
|
43906
|
43907
|
43908
|
43925
|
43926
|
43927
|
43928
|
43929
|
43930
|
43953