Bugzilla – Attachment 41620 Details for
Bug 11229
makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11229: makepayment doesn't log branch in statistics correctly
Bug-11229-makepayment-doesnt-log-branch-in-statist.patch (text/plain), 1.79 KB, created by
Jonathan Druart
on 2015-08-18 15:54:22 UTC
(
hide
)
Description:
Bug 11229: makepayment doesn't log branch in statistics correctly
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-08-18 15:54:22 UTC
Size:
1.79 KB
patch
obsolete
>From b43630993ca8bcbdb2d69e3059c2c9a5efae4b7f Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Mon, 8 Jun 2015 03:51:02 +0200 >Subject: [PATCH] Bug 11229: makepayment doesn't log branch in statistics > correctly > >This patch fixes makepayment() so it correctly logs the branch code >to the statistics table. > >To test: >- Run (with the regression tests applied) > $ prove t/db_dependent/Accounts.t >=> FAIL: makepayment() tests fail because logging is wrong >- Apply the patch >- Run > $ prove t/db_dependent/Accounts.t >=> SUCCESS: tests for makepayment now pass >(Note: makepartialpayment tests still fail as they need the next patch) > >Original commit message relying on the UI to test: > >There are several ways of paying fines, not all of them >recorded the branch the payment was made at correctly: > >1) Pay button next to an individual fine >2) Checkbox + pay amount >3) Checkbox + pay selected > >For each of those, check if the payment registered in >the table statistics contains the branchcode before >and after the patch. > >The patch should fix 1). >2) and 3) are ok with and without the patch. > >Important: Don't change the amount, pay individual fines. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >Note: i fixed the commit message, because this is a fix for makepayment > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Accounts.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index d0709d0..d798b34 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -276,7 +276,7 @@ sub makepayment { > } > > UpdateStats({ >- branch => $user, >+ branch => $branch, > type => 'payment', > amount => $amount, > borrowernumber => $borrowernumber, >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11229
:
39971
|
41473
|
41474
|
41475
|
41619
| 41620 |
41621
|
41622
|
41623