Bugzilla – Attachment 41621 Details for
Bug 11229
makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11229: (followup) makepartialpayment fix
Bug-11229-followup-makepartialpayment-fix.patch (text/plain), 2.08 KB, created by
Jonathan Druart
on 2015-08-18 15:54:26 UTC
(
hide
)
Description:
Bug 11229: (followup) makepartialpayment fix
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-08-18 15:54:26 UTC
Size:
2.08 KB
patch
obsolete
>From 611e31c5abfcf01c05bb95df7d39c3794a6d0991 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >Date: Thu, 13 Aug 2015 12:03:15 -0300 >Subject: [PATCH] Bug 11229: (followup) makepartialpayment fix > >makepartialpayment() wasn't logging the branch either. This patch >fixes that too. > >To test: >- Run (with the regression tests applied) > $ prove t/db_dependent/Accounts.t >=> FAIL: tests fail because makepartialpayment is not logging the branch code >- Apply the patch >- Run > $ prove t/db_dependent/Accounts.t >=> SUCCESS: tests pass >- Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Accounts.pm | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index d798b34..9ca87e3 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -276,12 +276,12 @@ sub makepayment { > } > > UpdateStats({ >- branch => $branch, >- type => 'payment', >- amount => $amount, >- borrowernumber => $borrowernumber, >- accountno => $accountno} >- ); >+ branch => $branch, >+ type => 'payment', >+ amount => $amount, >+ borrowernumber => $borrowernumber, >+ accountno => $accountno >+ }); > > #check to see what accounttype > if ( $data->{'accounttype'} eq 'Rep' || $data->{'accounttype'} eq 'L' ) { >@@ -726,12 +726,12 @@ sub makepartialpayment { > '', 'Pay', $data->{'itemnumber'}, $manager_id, $payment_note); > > UpdateStats({ >- branch => $user, >- type => 'payment', >- amount => $amount, >- borrowernumber => $borrowernumber, >- accountno => $accountno} >- ); >+ branch => $branch, >+ type => 'payment', >+ amount => $amount, >+ borrowernumber => $borrowernumber, >+ accountno => $accountno >+ }); > > if ( C4::Context->preference("FinesLog") ) { > logaction("FINES", 'CREATE',$borrowernumber,Dumper({ >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11229
:
39971
|
41473
|
41474
|
41475
|
41619
|
41620
| 41621 |
41622
|
41623