Bugzilla – Attachment 41705 Details for
Bug 14505
single quotes in journal number cause print routing list window to not appear
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14505: single quotes in journal number cause print routing list window to not appear
Bug-14505-single-quotes-in-journal-number-cause-pr.patch (text/plain), 1.75 KB, created by
Joonas Kylmälä
on 2015-08-20 09:35:58 UTC
(
hide
)
Description:
Bug 14505: single quotes in journal number cause print routing list window to not appear
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2015-08-20 09:35:58 UTC
Size:
1.75 KB
patch
obsolete
>From 29501ec745a643c02984c340d70c32a20e5e38ef Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <j.kylmala@gmail.com> >Date: Thu, 20 Aug 2015 09:24:17 +0000 >Subject: [PATCH] Bug 14505: single quotes in journal number cause print > routing list window to not appear > >Escapes single quotes from serial.serialseq string. > >Test plan: > >1. Have a serial with a number which has single quote in it. >2. Go to Serials -> Find some serial subscription -> Serial collection. >3. Set up a routing list for this serial. >4. Click on Print list under the column Routing. >5. Notice that the print window doesn't open. >6. Apply patch. >7. Notice that the print window opens. > >Sponsored-by: Vaara-kirjastot >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index 4418baf..43bae8c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -294,7 +294,7 @@ $(document).ready(function() { > </td> > [% IF ( routing ) %] > <td> >- <a href="" onclick="print_slip([% serial.subscriptionid |html %], '[% serial.serialseq |html %] ([% serial.publisheddate | $KohaDates %])'); return false" >Print list</a> >+ <a href="" onclick="print_slip([% serial.subscriptionid |html %], '[% serial.serialseq.replace("'", "\\'") |html %] ([% serial.publisheddate | $KohaDates %])'); return false" >Print list</a> > </td> > [% END %] > </tr> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14505
:
41705
|
42106
|
42140