Bugzilla – Attachment 41709 Details for
Bug 14337
AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
Bug-14337---AllowRenewalIfOtherItemsAvailable-coun.patch (text/plain), 1.68 KB, created by
Kyle M Hall (khall)
on 2015-08-20 11:16:44 UTC
(
hide
)
Description:
Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-08-20 11:16:44 UTC
Size:
1.68 KB
patch
obsolete
>From ed8a1a8bb2513d496440182f3f4580236ef72a92 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 5 Jun 2015 07:50:26 -0400 >Subject: [PATCH] Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability > >AllowRenewalIfOtherItemsAvailable checks >C4::Reserves::IsAvailableForItemLevelRequest to see if the item is >holdable, which catches not for loan values less than 0 ( i.e. holdable, >but not circ-able ). However, since this feature is about >actually checking out items to patrons, we should not count *any* not >for loan items when deciding if the available items will satisfy all >current holds. > >Test Plan: > 1) Enable AllowRenewalIfOtherItemsAvailable > 2) Create a record with two items > 3) Check out one item to a patron > 4) Ensure the item is renewable > 5) Place a hold on the record > 6) The item should now be non-renewable > 7) Add a second item to the record, but with a not for loan value < 0 > 8) Note the checkout is still renewable > 9) Apply this patch >10) Note the checkout is now non-renewable > >Works ok. > >Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> >--- > C4/Circulation.pm | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 7813e33..5177203 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2693,6 +2693,7 @@ sub CanBookBeRenewed { > { > biblionumber => $resrec->{biblionumber}, > onloan => undef, >+ notforloan => 0, > -not => { itemnumber => $itemnumber } > }, > { columns => 'itemnumber' } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14337
:
39898
|
41262
|
41263
|
41569
|
41708
|
41709
|
41787
|
41788
|
41904
|
41905
|
41906
|
41907
|
50840
|
50841