Attachment 41761 Details for Bug 9809 – Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee

[patch] Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee

Bug-9809-QA-Follow-up-Remove-an-erroneous-call-to-.patch (text/plain), 1.98 KB, created by Marcel de Rooy on 2015-08-21 09:00:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-08-21 09:00:19 UTC

Size: 1.98 KB

patch

obsolete

>From d78c381f68ead2963e25922bd9c59b55203c82f0 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 21 Aug 2015 10:47:19 +0200
>Subject: [PATCH] Bug 9809: [QA Follow-up] Remove an erroneous call to
> GetReserveFee
>Content-Type: text/plain; charset=utf-8
>
>The call to GetReserveFee in opac-reserve.pl is useless in its current
>form. The first parameter undef takes care of receiving 0.
>But note that the user is warned correctly for the charge via param
>variable RESERVE_CHARGE on the opac form.
>
>When the hold is placed, AddReserve calls GetReserveFee. So if the routine
>would work correctly, we would not need this extra call in opac-reserve
>in the whole place. Unfortunately, the routine is not working correctly.
>
>I will submit a fix for GetReserveFee under a new report (14702).
>
>Test plan:
>[1] Add a hold fee to some category.
>[2] Check the warn for placing a hold on such a book in OPAC.
>[3] Observe that the actual fee is not charged. This is a current bug and
>    it will be addressed on report 14702.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-reserve.pl |    7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 6e6e928..4dff9a2 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -410,13 +410,6 @@ foreach my $biblioNum (@biblionumbers) {
>     }
> 
>     foreach my $itemInfo (@{$biblioData->{itemInfos}}) {
>-        $debug and warn $itemInfo->{'notforloan'};
>-
>-        # Get reserve fee.
>-        my $fee = GetReserveFee(undef, $borrowernumber, $itemInfo->{'biblionumber'}, 'a',
>-                                ( $itemInfo->{'biblioitemnumber'} ) );
>-        $itemInfo->{'reservefee'} = sprintf "%.02f", ($fee ? $fee : 0.0);
>-
>         if ($itemLevelTypes && $itemInfo->{itype}) {
>             $itemInfo->{description} = $itemTypes->{$itemInfo->{itype}}{description};
>             $itemInfo->{imageurl} = getitemtypeimagesrc() . "/". $itemTypes->{$itemInfo->{itype}}{imageurl};
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9809: 37638 | 40733 | 40734 | 40735 | 40736 | 40737 | 40738 | 41754 | 41755 | 41756 | 41757 | 41758 | 41759 | 41760 | 41761 | 41767 | 41768 | 41769 | 41770 | 41771 | 41772 | 41773 | 41774 | 41809 | 41810 | 41811 | 41812 | 41813 | 41814 | 41815 | 41816 | 41817 | 41845 | 41848 | 41849 | 41850 | 41851 | 41852 | 41892 | 41893 | 41894 | 41895 | 41896 | 41897 | 41898 | 41899 | 41900 | 41901 | 41902 | 41903