Attachment 41845 Details for Bug 9809 – Bug 9809: [QA Follow-up] Still found some remains

[patch] Bug 9809: [QA Follow-up] Still found some remains

Bug-9809-QA-Follow-up-Still-found-some-remains.patch (text/plain), 2.83 KB, created by Marcel de Rooy on 2015-08-24 12:09:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-08-24 12:09:36 UTC

Size: 2.83 KB

patch

obsolete

>From 82b1fa2284049138697d4a156a15c4f111b8945b Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 24 Aug 2015 13:50:08 +0200
>Subject: [PATCH] Bug 9809: [QA Follow-up] Still found some remains
>Content-Type: text/plain; charset=utf-8
>
>In the staff client we had still some remains referring to the
>constraint types.
>Also touched one comment line from SIP.
>
>Test plan:
>Add a hold in the staff client.
>---
> C4/SIP/ILS/Item.pm | 1 -
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 ------
> reserve/request.pl | 2 --
> 3 files changed, 9 deletions(-)
>
>diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
>index 0f5f816..4586fee 100644
>--- a/C4/SIP/ILS/Item.pm
>+++ b/C4/SIP/ILS/Item.pm
>@@ -47,7 +47,6 @@ our $VERSION = 3.07.00.049;
> itemnumber => '823',
> priority => '1',
> reservenotes => undef,
>- constrainttype => 'a',
> reservedate => '2008-10-09',
> found => undef,
> rtimestamp => '2008-10-09 11:15:06',
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 80be359..a6a8f91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -769,7 +769,6 @@ function checkMultiHold() {
> [% END %]
> </a>
> [% ELSE %]
>- [% IF ( reserveloo.constrainttypea ) %]
> [% IF ( reserveloo.item_level_hold ) %]
> Only item
> <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% reserveloo.biblionumber %]">
>@@ -785,11 +784,6 @@ function checkMultiHold() {
> Next available
> <input type="hidden" name="itemnumber" value="" />
> [% END %]
>- [% ELSE %]
>- [% IF ( reserveloo.constrainttypeo ) %]
>- only this type :[% reserveloo.volumeddesc %] [% reserveloo.itemtype %]
>- [% END %]
>- [% END %]
> [% END %]
> </td>
> 
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 62f82a8..06dc6bf 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -526,8 +526,6 @@ foreach my $biblionumber (@biblionumbers) {
> $reserve{'notes'} = $res->{'reservenotes'};
> $reserve{'wait'} =
> ( ( defined $res->{'found'} and $res->{'found'} eq 'W' ) or ( $res->{'priority'} eq '0' ) );
>- $reserve{'constrainttypea'} = ( $res->{'constrainttype'} eq 'a' );
>- $reserve{'constrainttypeo'} = ( $res->{'constrainttype'} eq 'o' );
> $reserve{'voldesc'} = $res->{'volumeddesc'};
> $reserve{'ccode'} = $res->{'ccode'};
> $reserve{'barcode'} = $res->{'barcode'};
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9809: 37638 | 40733 | 40734 | 40735 | 40736 | 40737 | 40738 | 41754 | 41755 | 41756 | 41757 | 41758 | 41759 | 41760 | 41761 | 41767 | 41768 | 41769 | 41770 | 41771 | 41772 | 41773 | 41774 | 41809 | 41810 | 41811 | 41812 | 41813 | 41814 | 41815 | 41816 | 41817 | 41845 | 41848 | 41849 | 41850 | 41851 | 41852 | 41892 | 41893 | 41894 | 41895 | 41896 | 41897 | 41898 | 41899 | 41900 | 41901 | 41902 | 41903