Attachment 41864 Details for Bug 13918 – Bug 13918 [QA Followup]

[patch] Bug 13918 [QA Followup]

Bug-13918-QA-Followup.patch (text/plain), 3.52 KB, created by Kyle M Hall (khall) on 2015-08-24 15:12:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-08-24 15:12:03 UTC

Size: 3.52 KB

patch

obsolete

>From c5f0c3fc2119bc24dbd48492a375557600d39f1a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 24 Aug 2015 11:10:58 -0400
>Subject: [PATCH] Bug 13918 [QA Followup]
>
>---
> Koha/Biblio.pm                                     |   12 +++++++++---
> .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    6 +++---
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index 2145a04..ee6fa94 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -37,14 +37,20 @@ Koha::Biblio - Koha Biblio Object class
> 
> =cut
> 
>-=head3 subtitle
>+=head3 subtitles
>+
>+my @subtitles = $biblio->subtitles();
>+
>+Returns list of subtitles for a record.
>+
>+Keyword to MARC mapping for subtitle must be set for this method to return any possible values.
> 
> =cut
> 
>-sub subtitle {
>+sub subtitles {
>     my ( $self ) = @_;
> 
>-    return GetRecordValue( 'subtitle', GetMarcBiblio( $self->id() ), GetFrameworkCode( $self->id() ) );
>+    return GetRecordValue( 'subtitle', GetMarcBiblio( $self->id ), $self->frameworkcode );
> }
> 
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 3a2cc76..3cbc83d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -527,7 +527,7 @@
>                                             <td class="title">
>                                                 <a class="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% RESERVE.biblionumber %]">
>                                                     [% RESERVE.biblio.title %]
>-                                                    [% FOREACH subtitl IN RESERVE.biblio.subtitle %]
>+                                                    [% FOREACH subtitl IN RESERVE.biblio.subtitles %]
>                                                         [% subtitl.subfield %]
>                                                     [% END %]
>                                                     [% RESERVE.item.enumchron %]
>@@ -612,9 +612,9 @@
>                                                                         <div class="modal-header">
>                                                                             <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button>
>                                                                             [% IF RESERVE.suspend %]
>-                                                                                <h3 id="suspendModal[% RESERVE.reserve_id %]Label">Resume your hold on <i>[% RESERVE.reserves_title %]</i></h3>
>+                                                                                <h3 id="suspendModal[% RESERVE.reserve_id %]Label">Resume your hold on <i>[% RESERVE.biblio.title %]</i></h3>
>                                                                             [% ELSE %]
>-                                                                                <h3 id="suspendModal[% RESERVE.reserve_id %]Label">Suspend your hold on <i>[% RESERVE.reserves_title %]</i></h3>
>+                                                                                <h3 id="suspendModal[% RESERVE.reserve_id %]Label">Suspend your hold on <i>[% RESERVE.biblio.title %]</i></h3>
>                                                                             [% END %]
>                                                                         </div>
>                                                                         <div class="modal-body">
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13918: 37271 | 37272 | 40033 | 40035 | 41862 | 41863 | 41864 | 41865 | 41945 | 41946 | 41947 | 41948 | 42652 | 42653 | 42654 | 42655 | 42656 | 42745 | 42746 | 42747 | 42748 | 42749 | 42779 | 42780 | 42781 | 42782 | 42783 | 43429 | 43430 | 43431 | 43432 | 43433 | 43438 | 43502 | 43503 | 43504 | 43505 | 43506 | 43507 | 46130 | 46131 | 46132 | 46133 | 46134 | 46135