Attachment 41871 Details for Bug 14717 – Bug 14717: Invalid dates in debarred column

[patch] Bug 14717: Invalid dates in debarred column

Bug-14717-Invalid-dates-in-debarred-column.patch (text/plain), 1.23 KB, created by Chris Cormack on 2015-08-24 22:03:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2015-08-24 22:03:25 UTC

Size: 1.23 KB

patch

obsolete

>From 39c58f56fc2b223aa82d0fd327507ac9b0e43bc4 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Tue, 25 Aug 2015 10:00:20 +1200
>Subject: [PATCH] Bug 14717: Invalid dates in debarred column
>
>To test
>1/ Import a patron using the patron import tool, make sure they have
>no debarred column in the file
>2/ Check the database, notice the debarred column is 0000-00-00
>3/ For bonus points, checkout an item to that borrower, then check it in
>notice Koha errors
>4/ Apply patch
>5/ Import a new patron
>6/ Notice column is now NULL and that checkins work
>---
> C4/Members.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index 95fb4e7..1477928 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -757,7 +757,10 @@ sub AddMember {
> 
>     # create a disabled account if no password provided
>     $data{'password'} = ($data{'password'})? hash_password($data{'password'}) : '!';
>+
>+    # we don't want invalid dates in the db (mysql has a bad habit of inserting 0000-00-00
>     $data{'dateofbirth'} = undef if( not $data{'dateofbirth'} );
>+    $data{'debarred'} = undef if ( not $data{'debarred'} );
> 
>     # get only the columns of Borrower
>     my @columns = $schema->source('Borrower')->columns;
>-- 
>2.5.0

Actions: View | Diff | Splinter Review

Attachments on bug 14717: 41871 | 42331 | 42342 | 42343 | 42344 | 42356 | 42357 | 42358