Attachment 41898 Details for Bug 9809 – Bug 9809: [QA Follow-up] Remove warnings from Hold.pm

[patch] Bug 9809: [QA Follow-up] Remove warnings from Hold.pm

Bug-9809-QA-Follow-up-Remove-warnings-from-Holdpm.patch (text/plain), 1.64 KB, created by Jonathan Druart on 2015-08-25 11:37:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-08-25 11:37:23 UTC

Size: 1.64 KB

patch

obsolete

>From 65e0435ee77775ab1e3c784ddab8f1b55ef4fbee Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 21 Aug 2015 09:23:53 +0200
>Subject: [PATCH] Bug 9809: [QA Follow-up] Remove warnings from Hold.pm
>
>Resolves two warnings on a uninitialized found column:
>holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152
>holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152
>
>Test plan:
>Run t/db_dependent/Hold.t.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/Hold.pm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index b874f13..ad84af3 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -50,7 +50,8 @@ Returns undef if the hold is not waiting ( found = 'W' ).
> sub waiting_expires_on {
>     my ($self) = @_;
> 
>-    return unless $self->found() eq 'W';
>+    my $found = $self->found;
>+    return unless $found && $found eq 'W';
> 
>     my $ReservesMaxPickUpDelay = C4::Context->preference('ReservesMaxPickUpDelay');
>     return unless $ReservesMaxPickUpDelay;
>@@ -71,7 +72,8 @@ Returns true if hold is a waiting hold
> sub is_waiting {
>     my ($self) = @_;
> 
>-    return $self->found() eq 'W';
>+    my $found = $self->found;
>+    return $found && $found eq 'W';
> }
> 
> =head3 biblio
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 9809: 37638 | 40733 | 40734 | 40735 | 40736 | 40737 | 40738 | 41754 | 41755 | 41756 | 41757 | 41758 | 41759 | 41760 | 41761 | 41767 | 41768 | 41769 | 41770 | 41771 | 41772 | 41773 | 41774 | 41809 | 41810 | 41811 | 41812 | 41813 | 41814 | 41815 | 41816 | 41817 | 41845 | 41848 | 41849 | 41850 | 41851 | 41852 | 41892 | 41893 | 41894 | 41895 | 41896 | 41897 | 41898 | 41899 | 41900 | 41901 | 41902 | 41903