Attachment 41928 Details for Bug 14714 – [PASSED QA] Bug 14714: Add tab-completion to koha-mysql command

[patch] [PASSED QA] Bug 14714: Add tab-completion to koha-mysql command

PASSED-QA-Bug-14714-Add-tab-completion-to-koha-mys.patch (text/plain), 1.83 KB, created by Kyle M Hall (khall) on 2015-08-25 14:57:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-08-25 14:57:32 UTC

Size: 1.83 KB

patch

obsolete

>From ef706697da7447bbd34543db555e438fee63513d Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 24 Aug 2015 15:44:22 -0300
>Subject: [PATCH] [PASSED QA] Bug 14714: Add tab-completion to koha-mysql command
>
>This patch introduces tab-completion in bash to the koha-mysql
>command. It completes using valid instance names. It stops completing
>once an instance name is chosen (i.e. it respects the fact that
>koha-mysql accepts only one instance name as parameter).
>
>To test:
>- Have a packages install (kohadevbox works)
>- Run:
>  $ . debian/koha-common.bash-completion
>- Type
>  koha-mysql <tab>
>=> SUCCESS: You are prompted valid instance names for completion.
>- Sign off :-D
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> debian/koha-common.bash-completion |   18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
>diff --git a/debian/koha-common.bash-completion b/debian/koha-common.bash-completion
>index 07bcdc1..d65aba2 100644
>--- a/debian/koha-common.bash-completion
>+++ b/debian/koha-common.bash-completion
>@@ -43,6 +43,21 @@ _build_substract_instances()
>     echo "$substract"
> }
> 
>+_koha_single_instance()
>+{
>+    local filter=$1
>+
>+    cur=${COMP_WORDS[COMP_CWORD]}
>+    prev=${COMP_WORDS[COMP_CWORD-1]}
>+    if [ $COMP_CWORD -eq 1 ]; then
>+        COMPREPLY=( $( compgen -W "$(koha-list $filter)" $cur ) )
>+    else
>+        COMPREPLY=()
>+    fi
>+
>+    return 0
>+}
>+
> _koha_list_cmd()
> {
>     local filter=$1
>@@ -120,6 +135,9 @@ complete -F _koha_enabled_instances koha-start-zebra
> complete -F _koha_enabled_instances koha-restart-zebra
> complete -F _koha_enabled_instances koha-stop-zebra
> 
>+# koha-mysql autocompletes with a single instance name
>+complete -F _koha_single_instance koha-mysql
>+
> _koha_list()
> {
>     local cur opts substract
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14714: 41867 | 41868 | 41928