Bugzilla – Attachment 41990 Details for
Bug 14634
Warns when placing hold on record with no items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14634: Warns when placing hold on record with no items
Bug-14634-Warns-when-placing-hold-on-record-with-n.patch (text/plain), 1.18 KB, created by
Jonathan Druart
on 2015-08-26 14:09:32 UTC
(
hide
)
Description:
Bug 14634: Warns when placing hold on record with no items
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-08-26 14:09:32 UTC
Size:
1.18 KB
patch
obsolete
>From f16d329b332eebd14e9096cc3e036e68c6ec2f09 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 3 Aug 2015 02:23:29 +0000 >Subject: [PATCH] Bug 14634: Warns when placing hold on record with no items > >To test: > >1) Create a new record in Cataloguing >2) When done, instead of adding an item to the record, click on the Holds tab in the left nav >3) Notice warns >4) Apply patch and refresh page >5) Click on Holds tab again >6) Notice warns are gone and page still works > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Warns disappear; note that the display of the error message is still ugly. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > reserve/request.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 62f82a8..0bfe5e9 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -201,6 +201,7 @@ foreach my $biblionumber (@biblionumbers) { > my $dat = GetBiblioData($biblionumber); > > my $canReserve = CanBookBeReserved( $borrowerinfo->{borrowernumber}, $biblionumber ); >+ $canReserve //= ''; > if ( $canReserve eq 'OK' ) { > > #All is OK and we can continue >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14634
:
41308
|
41912
| 41990