Attachment 41997 Details for Bug 14733 – Bug 14733 - Prevent a record from having holds with duplicate priorities

[patch] Bug 14733 - Prevent a record from having holds with duplicate priorities

Bug-14733---Prevent-a-record-from-having-holds-wit.patch (text/plain), 1.32 KB, created by Kyle M Hall (khall) on 2015-08-26 15:48:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-08-26 15:48:02 UTC

Size: 1.32 KB

patch

obsolete

>From 270bbdafd0d2fbff6b496293fc13a7a60bee886d Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 26 Aug 2015 11:43:08 -0400
>Subject: [PATCH] Bug 14733 - Prevent a record from having holds with duplicate priorities
>
>It is possible to create holds with duplicate priorities.
>
>The reason for this is that typically the priority is calculated before
>placing the hold. When the hold is placed the priority is calculated.
>This can easily be shown by opening up two browser windows and starting
>to place a hold for a record in each one. You'll see that both list the
>same priority. If you than place the hold in each window, both holds
>will have the same priority!
>
>Test Plan:
>1) Run unit tests pre-patch, note they fail
>2) Run unit tests post-patch, note they succeed
>---
> C4/Reserves.pm |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index a300a4a..75d9ffc 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -208,6 +208,8 @@ sub AddReserve {
>     );
>     my $reserve_id = $sth->{mysql_insertid};
> 
>+    _FixPriority({ biblionumber => $biblionumber});
>+
>     # Send e-mail to librarian if syspref is active
>     if(C4::Context->preference("emailLibrarianWhenHoldIsPlaced")){
>         my $borrower = C4::Members::GetMember(borrowernumber => $borrowernumber);
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14733: 41996 | 41997 | 41998 | 42658 | 42659 | 42734 | 42735 | 42736 | 42880