Attachment 42187 Details for Bug 14683 – [PASSED QA] Bug 14683: Unable to clear SMS number

[patch] [PASSED QA] Bug 14683: Unable to clear SMS number

PASSED-QA-Bug-14683-Unable-to-clear-SMS-number.patch (text/plain), 2.19 KB, created by Katrin Fischer on 2015-09-01 23:02:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-09-01 23:02:07 UTC

Size: 2.19 KB

patch

obsolete

>From 40af5388ca72324bc5c35b19f154345204aba5a9 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <j.kylmala@gmail.com>
>Date: Wed, 19 Aug 2015 11:42:50 +0000
>Subject: [PATCH] [PASSED QA] Bug 14683: Unable to clear SMS number
>
>Enables to clear SMS number.
>
>To test:
>1. Go to opac-messaging.pl
>2. Insert SMS number and submit
>3. Clear SMS number and submit
>4. Observe that the sms number did not change
>5. Apply patch
>6. Clear SMS number and submit
>7. Observe that the sms number changes
>
>Sponsored-by: Vaara-kirjastot
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Adding a follow-up.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> opac/opac-messaging.pl | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl
>index 69ae517..b3b192c 100755
>--- a/opac/opac-messaging.pl
>+++ b/opac/opac-messaging.pl
>@@ -50,8 +50,7 @@ my $messaging_options = C4::Members::Messaging::GetMessagingOptions();
> 
> if ( defined $query->param('modify') && $query->param('modify') eq 'yes' ) {
> 
>-    # If they've modified the SMS number, record it.
>-    if ( ( defined $query->param('SMSnumber') ) && ( $query->param('SMSnumber') ne $borrower->{'mobile'} ) ) {
>+    if ( $query->param('SMSnumber') ne $borrower->{'mobile'} )  {
>         ModMember( borrowernumber => $borrowernumber,
>                    smsalertnumber => $query->param('SMSnumber') );
>         $borrower = GetMemberDetails( $borrowernumber );
>@@ -65,7 +64,7 @@ C4::Form::MessagingPreferences::set_form_values({ borrowernumber     => $borrowe
> # warn( Data::Dumper->Dump( [ $messaging_options ], [ 'messaging_options' ] ) );
> $template->param( BORROWER_INFO         => [ $borrower ],
>                   messagingview         => 1,
>-                  SMSnumber => defined $borrower->{'smsalertnumber'} ? $borrower->{'smsalertnumber'} : $borrower->{'mobile'},
>+                  SMSnumber => $borrower->{'smsalertnumber'} ? $borrower->{'smsalertnumber'} : $borrower->{'mobile'},
>                   SMSSendDriver                =>  C4::Context->preference("SMSSendDriver"),
>                   TalkingTechItivaPhone        =>  C4::Context->preference("TalkingTechItivaPhoneNotification") );
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14683: 41664 | 42050 | 42051 | 42162 | 42187 | 42188 | 42189