Attachment 42190 Details for Bug 14205 – [PASSED QA] Bug 14205: Deleting an Item/Record does not remove link to course reserve

[patch] [PASSED QA] Bug 14205: Deleting an Item/Record does not remove link to course reserve

PASSED-QA-Bug-14205-Deleting-an-ItemRecord-does-no.patch (text/plain), 2.74 KB, created by Katrin Fischer on 2015-09-02 06:17:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-09-02 06:17:44 UTC

Size: 2.74 KB

patch

obsolete

>From 060c6b7072c1a92ea5f1e5b5f0bb9338645fafa4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 4 Aug 2015 10:00:51 +0100
>Subject: [PATCH] [PASSED QA] Bug 14205: Deleting an Item/Record does not
> remove link to course reserve
>
>A constraint is missing on the course_reserves.ci_id field.
>This patch adds it and removes orphan rows.
>
>Test plan:
>0/ Don't apply the patch
>1/ Login to Staff Site.
>2/ Go to Course Reserves
>3/ Create Course
>4/ Add Reserve
>5/ Go to item added (delete item/record)
>6/ Refresh Course (see no items attached)
>7/ Delete Course
>8/ See course still listed in the courses (Not deleted)
>9/ Apply the patch and execute the updatedatabase entry.
>10/ Delete the Course
>Note that the course has correctly been removed.
>
>NOTE: Make sure to set the UseCourseReserves system preference to test.
>      Tested before (problem existed) and after (problem solved) update.
>      Dropped DB, web installed, and put in dummy data and retested.
>      Problem solved.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../mysql/atomicupdate/bug_14205-add_fk_course_reserves_ci_id.sql     | 2 ++
> installer/data/mysql/kohastructure.sql                                | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_14205-add_fk_course_reserves_ci_id.sql
>
>diff --git a/installer/data/mysql/atomicupdate/bug_14205-add_fk_course_reserves_ci_id.sql b/installer/data/mysql/atomicupdate/bug_14205-add_fk_course_reserves_ci_id.sql
>new file mode 100644
>index 0000000..1a68545
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_14205-add_fk_course_reserves_ci_id.sql
>@@ -0,0 +1,2 @@
>+DELETE cr.* FROM course_reserves AS cr LEFT JOIN course_items USING(ci_id) WHERE course_items.ci_id IS NULL;
>+ALTER TABLE course_reserves add CONSTRAINT course_reserves_ibfk_2 FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) ON DELETE CASCADE ON UPDATE CASCADE;
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index e919349..fd58258 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -623,7 +623,9 @@ CREATE TABLE `course_reserves` (
> -- Constraints for table `course_reserves`
> --
> ALTER TABLE `course_reserves`
>-  ADD CONSTRAINT `course_reserves_ibfk_1` FOREIGN KEY (`course_id`) REFERENCES `courses` (`course_id`);
>+  ADD CONSTRAINT `course_reserves_ibfk_1` FOREIGN KEY (`course_id`) REFERENCES `courses` (`course_id`),
>+  ADD CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE;
>+
> 
> --
> -- Table structure for table `branch_borrower_circ_rules`
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14205: 41335 | 41390 | 42190 | 42221