Attachment 42260 Details for Bug 7634 – Bug 7634: Make the tests pass

[patch] Bug 7634: Make the tests pass

Bug-7634-Make-the-tests-pass.patch (text/plain), 1.46 KB, created by Chris Cormack on 2015-09-03 03:28:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2015-09-03 03:28:06 UTC

Size: 1.46 KB

patch

obsolete

>From b5ada7b86426c72610131153a6a3e46f6d3b48f4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 2 Sep 2015 14:43:15 +0100
>Subject: [PATCH] Bug 7634: Make the tests pass
>
>This patch just fixed a master bug, if your database already has some
>items.homebranch set to CPL
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> t/db_dependent/Items.t | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t
>index b1796bc..fb5d672 100755
>--- a/t/db_dependent/Items.t
>+++ b/t/db_dependent/Items.t
>@@ -236,6 +236,8 @@ subtest 'SearchItems test' => sub {
>     $dbh->{RaiseError} = 1;
> 
>     C4::Context->set_preference('marcflavour', 'MARC21');
>+    my $cpl_items_before = SearchItemsByField( 'homebranch', 'CPL');
>+
>     my ($biblionumber) = get_biblio();
> 
>     # Add branches if they don't exist
>@@ -384,8 +386,8 @@ subtest 'SearchItems test' => sub {
>     ($items, $total_results) = SearchItems($filter);
>     ok(scalar @$items == 1, 'found 1 item with itemnotes = "foobar"');
> 
>-    my $cpl_items = SearchItemsByField( 'homebranch', 'CPL');
>-    is( ( $cpl_items and scalar( @$cpl_items ) ), 1, 'SearchItemsByField should return something' );
>+    my $cpl_items_after = SearchItemsByField( 'homebranch', 'CPL');
>+    is( ( scalar( @$cpl_items_after ) - scalar ( @$cpl_items_before ) ), 1, 'SearchItemsByField should return something' );
> 
>     $dbh->rollback;
> };
>-- 
>2.5.1

Actions: View | Diff | Splinter Review

Attachments on bug 7634: 42222 | 42223 | 42224 | 42260 | 42261 | 42262 | 42495 | 42496 | 42497