Attachment 42262 Details for Bug 7634 – Bug 7634: Prevent permanent_location to be set to NULL if not defined

[patch] Bug 7634: Prevent permanent_location to be set to NULL if not defined

Bug-7634-Prevent-permanentlocation-to-be-set-to-NU.patch (text/plain), 1.44 KB, created by Chris Cormack on 2015-09-03 03:28:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2015-09-03 03:28:41 UTC

Size: 1.44 KB

patch

obsolete

>From 5acd94f33070a05b7374fef1aa6135ad2b40ef42 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 2 Sep 2015 14:28:52 +0100
>Subject: [PATCH] Bug 7634: Prevent permanent_location to be set to NULL if not
> defined
>
>The permanent_location is correctly filled when an item is added from
>the cataloguing module (routine set_item_default_location from
>cataloguing/additem.pl).
>But when records are imported, this filled is not managed. It's only on
>editing (_do_column_fixes_for_mod called from ModItem).
>
>This patch set the permanent_location item fields to the location value for all
>items created, even the imported ones.
>
>Test plan:
>0/ Do not apply this patch
>1/ Import a record with items using the "Stage MARC for import" tool
>2/ Check the values for the permanent_location in the items table.
>They are set to NULL
>3/ Apply this patch
>4/ Repeat 2 and confirm that now the permanent_location values are set
>to the location values.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> C4/Items.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 0e639dc..1c6d7ef 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2144,6 +2144,7 @@ sub _koha_new_item {
>     my ( $item, $barcode ) = @_;
>     my $dbh=C4::Context->dbh;  
>     my $error;
>+    $item->{permanent_location} //= $item->{location};
>     my $query =
>            "INSERT INTO items SET
>             biblionumber        = ?,
>-- 
>2.5.1

Actions: View | Diff | Splinter Review

Attachments on bug 7634: 42222 | 42223 | 42224 | 42260 | 42261 | 42262 | 42495 | 42496 | 42497