Bugzilla – Attachment 42354 Details for
Bug 14784
Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
CAM 2267 - Bug 14784 : Fix checkin message for debarred patrons
CAM-2267---Bug-14784--Fix-checkin-message-for-deba.patch (text/plain), 1.80 KB, created by
Genevieve Plantin
on 2015-09-03 20:42:52 UTC
(
hide
)
Description:
CAM 2267 - Bug 14784 : Fix checkin message for debarred patrons
Filename:
MIME Type:
Creator:
Genevieve Plantin
Created:
2015-09-03 20:42:52 UTC
Size:
1.80 KB
patch
obsolete
>From 5e00c3990fd50c3d99878ce4461dbdd099c9b9b8 Mon Sep 17 00:00:00 2001 >From: genevieve <genevieve.plantin@inlibro.com> >Date: Thu, 3 Sep 2015 16:40:00 -0400 >Subject: [PATCH] CAM 2267 - Bug 14784 : Fix checkin message for debarred > patrons > >If there is an overdue but finedays equals 0, then we have to see if the patron is debarred and if he was forever debarred. So we have to go through the same code a if it was a debarred patron with no overdue. >--- > C4/Circulation.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 9fc2987..6f095ef 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1950,6 +1950,7 @@ sub AddReturn { > } > } > >+ my $show_checkin_message = 0; > # fix up the overdues in accounts... > if ($borrowernumber) { > my $fix = _FixOverduesOnReturn($borrowernumber, $item->{itemnumber}, $exemptfine, $dropbox); >@@ -1964,8 +1965,15 @@ sub AddReturn { > } else { > $messages->{'Debarred'} = $debardate if $debardate; > } >+ if (!$debardate && $borrower->{debarred}) { >+ $show_checkin_message = 1; >+ } > # there's no overdue on the item but borrower had been previously debarred > } elsif ( $issue->{date_due} and $borrower->{'debarred'} ) { >+ $show_checkin_message = 1; >+ } >+ >+ if ($show_checkin_message) { > if ( $borrower->{debarred} eq "9999-12-31") { > $messages->{'ForeverDebarred'} = $borrower->{'debarred'}; > } else { >@@ -1975,7 +1983,7 @@ sub AddReturn { > if ( DateTime->compare( $borrower_debar_dt, $today_dt ) != -1 ) { > $messages->{'PrevDebarred'} = $borrower->{'debarred'}; > } >- } >+ } > } > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14784
:
42354
|
49282
|
49283
|
49377
|
58227
|
67102
|
68132
|
69295
|
69296
|
77683
|
79826
|
106808
|
106809
|
107487
|
110485
|
110514
|
110763
|
110764
|
112724
|
112725
|
136040
|
136327
|
137727
|
137728
|
145320
|
145321