Bugzilla – Attachment 42367 Details for
Bug 14649
fund names not displayed in budget planning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14649: Followup - correct budget_period_id in fund name link
PASSED-QA-Bug-14649-Followup---correct-budgetperio.patch (text/plain), 2.17 KB, created by
Katrin Fischer
on 2015-09-03 22:33:41 UTC
(
hide
)
Description:
[PASSED QA] Bug 14649: Followup - correct budget_period_id in fund name link
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-09-03 22:33:41 UTC
Size:
2.17 KB
patch
obsolete
>From 5300e9c741f380256412f5c31a295e3b2fd40b74 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 6 Aug 2015 09:36:42 +0200 >Subject: [PATCH] [PASSED QA] Bug 14649: Followup - correct budget_period_id in > fund name link > >Now that fund name is displayed in the table as a link, you see that arg budget_period_id is never defined in this link. > >This is because the template var is [% budget_line.budget_period_id %] instead of [% budget_period_id %]. >This looks like a mistake when converting from tmpl to tt. > >Test plan : >- Without patch >- Look for a planning with funds : > /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS >- Click on a fund name >=> You see in URL that budget_period_id is empty : > /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id= >- Apply patch >- Look for a planning with funds : > /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS >- Click on a fund name >=> you see in URL that budget_period_id is defined like in planning page : > /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2 > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt >index 89c7456..2510d04 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt >@@ -132,7 +132,7 @@ > [% ELSE %] > <td> > [% END %] >- <a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=[% budget_line.budget_id %]&budget_period_id=[% budget_line.budget_period_id %]">[% budget_line.budget_name %]</a></td> >+ <a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=[% budget_line.budget_id %]&budget_period_id=[% budget_period_id %]">[% budget_line.budget_name %]</a></td> > <td><span id="[% budget_line.budget_amount %]">[% budget_line.budget_amount | $Price %] </span> > > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14649
:
41396
|
41397
|
41398
|
41703
|
42268
|
42269
|
42367
|
42368
|
42369