Attachment 42389 Details for Bug 14721 – Bug 14721 - OAI-PMH must return error when no results

[patch] Bug 14721 - OAI-PMH must return error when no results

Bug-14721---OAI-PMH-must-return-error-when-no-resu.patch (text/plain), 1.72 KB, created by Mirko Tietgen on 2015-09-04 11:32:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mirko Tietgen

Created: 2015-09-04 11:32:22 UTC

Size: 1.72 KB

patch

obsolete

>From 23cf0b8a8045de56f93d1a23e23207026ed36273 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 25 Aug 2015 11:33:04 +0200
>Subject: [PATCH] Bug 14721 - OAI-PMH must return error when no results
>
>When getting records from OAI-PMH, an error must be returned if there is no results.
>
>See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions
>
>Test plan :
>- Enable OAI webservice
>- Perform a query that will return no results. ie : /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31
>=> Without patch you get a response with :
>   <ListRecords/>
>=> With patch you get a response with error code :
>   <error code="noRecordsMatch">No records match the given criteria</error>
>- Check a good query returns still results
>- Same test with ListIdentifiers verb
>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>---
> opac/oai.pl |   16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
>diff --git a/opac/oai.pl b/opac/oai.pl
>index ab56d79..573f01a 100755
>--- a/opac/oai.pl
>+++ b/opac/oai.pl
>@@ -411,6 +411,14 @@ sub new {
>         ) );
>     }
> 
>+    # Return error if no results
>+    unless ($count) {
>+        return HTTP::OAI::Response->new(
>+            requestURL => $repository->self_url(),
>+            errors     => [ new HTTP::OAI::Error( code => 'noRecordsMatch' ) ],
>+        );
>+    }
>+
>     return $self;
> }
> 
>@@ -586,6 +594,14 @@ sub new {
>         }
>     }
> 
>+    # Return error if no results
>+    unless ($count) {
>+        return HTTP::OAI::Response->new(
>+            requestURL => $repository->self_url(),
>+            errors     => [ new HTTP::OAI::Error( code => 'noRecordsMatch' ) ],
>+        );
>+    }
>+
>     return $self;
> }
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14721: 41887 | 42389 | 42404