Bugzilla – Attachment 42402 Details for
Bug 14343
Links to results pages don't work in receive shipment list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14343 Incorrect links to results pages in Receive Shipment List
Bug-14343-Incorrect-links-to-results-pages-in-Rece.patch (text/plain), 2.99 KB, created by
Jonathan Druart
on 2015-09-04 13:54:22 UTC
(
hide
)
Description:
Bug 14343 Incorrect links to results pages in Receive Shipment List
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-09-04 13:54:22 UTC
Size:
2.99 KB
patch
obsolete
>From d00964d17f86e14ecc05db7dc3aef2f5f5ee036d Mon Sep 17 00:00:00 2001 >From: Lyon3 Team <koha@univ-lyon3.fr> >Date: Fri, 5 Jun 2015 15:37:57 +0200 >Subject: [PATCH] Bug 14343 Incorrect links to results pages in Receive > Shipment List > >Numbered links have incorrect url. Links to result pages >don't work in Receive Shipment List (but fortunately, Next >and Previous buttons work) It's because the booksellerid is >not furnished in the url. > >Test Plan : >1) Go to Acquisitions module, enter a bookseller name that you > know you can get many page of invoices for and search for it. > >2) click on Receive shipment button. > >3) On bottom of the first results page, click on page number 2 > link. (cf joined screencast) > >You'll see that the results include invoices from other >booksellerid. Indeed, I suppose that you get results from all booksellerid. > >Intall patch and redo 3 steps. > >NOTE: I did not follow this test plan. > I read the acqui/parcels.pl code. > The template parameter numbers is assigned in a function which has > no reference to booksellerid at all! > Additionally, the booksellerid is set directly elsewhere. > It is also strange that the booksellerid references before and after > this loop do not use the numbers.booksellerid, but just booksellerid. > The change from numbers.booksellerid to booksellerid is correct! > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >index 486fac2..9eabbdb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >@@ -139,7 +139,7 @@ > [% IF ( number.highlight ) %] > <span class="current">[% number.number %]</span> > [% ELSE %] >- <a href="parcels.pl?booksellerid=[% number.booksellerid %]&startfrom=[% number.startfrom %][% IF ( number.datefrom ) %]&datefrom=[% number.datefrom %][% END %][% IF ( number.dateto ) %]&dateto=[% number.dateto %][% END %][% IF ( number.code ) %]&filter=[% number.code %][% END %][% IF ( number.orderby ) %]&orderby=[% number.orderby %][% END %][% IF ( number.resultsperpage ) %]&resultsperpage=[% number.resultsperpage %][% END %]&type=intra">[% number.number %]</a> >+ <a href="parcels.pl?booksellerid=[% booksellerid %]&startfrom=[% number.startfrom %][% IF ( number.datefrom ) %]&datefrom=[% number.datefrom %][% END %][% IF ( number.dateto ) %]&dateto=[% number.dateto %][% END %][% IF ( number.code ) %]&filter=[% number.code %][% END %][% IF ( number.orderby ) %]&orderby=[% number.orderby %][% END %][% IF ( number.resultsperpage ) %]&resultsperpage=[% number.resultsperpage %][% END %]&type=intra">[% number.number %]</a> > [% END %] > [% END %] > [% IF ( displaynext ) %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14343
:
39905
|
39907
|
39910
| 42402 |
42403