Attachment 42499 Details for Bug 14782 – [PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid)

[patch] [PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid)

PASSED-QA-Bug-14782---Add-possibility-to-search-pa.patch (text/plain), 4.24 KB, created by Katrin Fischer on 2015-09-13 16:13:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-09-13 16:13:20 UTC

Size: 4.24 KB

patch

obsolete

>From 15d3cb721fb19c2c6813c69fa11a1a620583915c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Sat, 5 Sep 2015 16:41:58 +0200
>Subject: [PATCH] [PASSED QA] Bug 14782 - Add possibility to search patrons
> using the username (userid)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch makes it possible to search for users using the username (userid / login name).
>
>To test:
>
>- Apply patch
>- Do searches from Home > Patrons
>- Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid
>- Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left
>- Make sure that other searches behave as before
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <j.kylmala@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Utils/DataTables/Members.pm                             | 3 ++-
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 5 +++++
> koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt  | 5 +++++
> svc/members/search                                         | 2 +-
> 4 files changed, 13 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm
>index cdaa33f..4240fa0 100644
>--- a/C4/Utils/DataTables/Members.pm
>+++ b/C4/Utils/DataTables/Members.pm
>@@ -61,9 +61,10 @@ sub search {
>     # split on coma
>     $searchmember =~ s/,/ /g if $searchmember;
>     my $searchfields = {
>-        standard => 'surname,firstname,othernames,cardnumber',
>+        standard => 'surname,firstname,othernames,cardnumber,userid',
>         email => 'email,emailpro,B_email',
>         borrowernumber => 'borrowernumber',
>+        userid => 'userid',
>         phone => 'phone,phonepro,B_phone,altcontactphone,mobile',
>         address => 'streettype,address,address2,city,state,zipcode,country',
>         dateofbirth => 'dateofbirth',
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>index 646c70a..bb09574 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>@@ -32,6 +32,11 @@
>               [% ELSE %]
>                 <option value='borrowernumber'>Borrower number</option>
>               [% END %]
>+              [% IF searchfieldstype == "userid" %]
>+                <option selected="selected" value='userid'>Username</option>
>+              [% ELSE %]
>+                <option value='userid'>Username</option>
>+              [% END %]
>               [% IF searchfieldstype == "phone" %]
>                 <option selected="selected" value='phone'>Phone number</option>
>               [% ELSE %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index 877be25..603920b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -424,6 +424,11 @@ function filterByFirstLetterSurname(letter) {
>                 [% ELSE %]
>                   <option value='borrowernumber'>Borrower number</option>
>                 [% END %]
>+                [% IF searchfieldstype == "userid" %]
>+                  <option selected="selected" value='userid'>Username</option>
>+                [% ELSE %]
>+                  <option value='userid'>Username</option>
>+                [% END %]
>                 [% IF searchfieldstype == "phone" %]
>                   <option selected="selected" value='phone'>Phone number</option>
>                 [% ELSE %]
>diff --git a/svc/members/search b/svc/members/search
>index 6343e2e..1c2d644 100755
>--- a/svc/members/search
>+++ b/svc/members/search
>@@ -140,7 +140,7 @@ All following params are optional:
>     firstletter => search patrons with surname begins with this pattern (currently only used for 1 letter)
>     categorycode and branchcode => search patrons belong to a given categorycode or a branchcode
>     searchtype: can be 'contain' or 'start_with'
>-    searchfieldstype: Can be 'standard', 'email', 'borrowernumber', 'phone' or 'address'
>+    searchfieldstype: Can be 'standard', 'email', 'borrowernumber', 'userid', 'phone' or 'address'
> 
> =cut
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14782: 42420 | 42454 | 42498 | 42499