Bugzilla – Attachment 4254 Details for
Bug 6402
Lists sorted by year appear to be empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed off patch
0001-SIGNED-OFF-Fix-for-Bug-6402-Lists-sorted-by-year-app.patch (text/plain), 1.55 KB, created by
Katrin Fischer
on 2011-05-25 06:18:02 UTC
(
hide
)
Description:
Signed off patch
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-05-25 06:18:02 UTC
Size:
1.55 KB
patch
obsolete
>From a85e25c525b8964100fb6472aec647cbaa333fc3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 24 May 2011 12:11:07 -0400 >Subject: [PATCH] [SIGNED-OFF] Fix for Bug 6402, Lists sorted by year appear to be empty >Content-Type: text/plain; charset="utf-8" > >If you create a list, populate it with titles, and then change the sort to >"year" it will appear as if your list is empty. The SQL in VirtualShelves.pm's >GetShelfContents tries to accept "year" as a sort by but 'year' is not a valid >column name. > >The SQL pulls biblioitems.publicationyear. Changing this to >'biblioitems.publicationyear as year,' > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > C4/VirtualShelves.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 6ed7549..df54de8 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -292,7 +292,7 @@ sub GetShelfContents ($;$$$) { > } > my $query = > " SELECT vc.biblionumber, vc.shelfnumber, vc.dateadded, itemtypes.*, >- biblio.*, biblioitems.itemtype, biblioitems.publicationyear, biblioitems.publishercode, biblioitems.place, biblioitems.size, biblioitems.pages >+ biblio.*, biblioitems.itemtype, biblioitems.publicationyear as year, biblioitems.publishercode, biblioitems.place, biblioitems.size, biblioitems.pages > FROM virtualshelfcontents vc > LEFT JOIN biblio ON vc.biblionumber = biblio.biblionumber > LEFT JOIN biblioitems ON biblio.biblionumber = biblioitems.biblionumber >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6402
:
4245
| 4254