Bugzilla – Attachment 42541 Details for
Bug 14655
Cannot checkin without Anonymous Patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14655: Add a warning on the about page if patrons have requested privacy
PASSED-QA-Bug-14655-Add-a-warning-on-the-about-pag.patch (text/plain), 3.17 KB, created by
Katrin Fischer
on 2015-09-14 20:00:25 UTC
(
hide
)
Description:
[PASSED QA] Bug 14655: Add a warning on the about page if patrons have requested privacy
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-09-14 20:00:25 UTC
Size:
3.17 KB
patch
obsolete
>From a02be90a594ad94c117c9ef735fa67786534ff68 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Aug 2015 18:15:02 +0100 >Subject: [PATCH] [PASSED QA] Bug 14655: Add a warning on the about page if > patrons have requested privacy >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >New warning on the about page if at least a patron has requested a >privacy on checkin but the AnonymousPatron is not set to a valid patron. > >Works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > about.pl | 5 +++++ > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 +++ > 2 files changed, 8 insertions(+) > >diff --git a/about.pl b/about.pl >index 29777cf..dbed815 100755 >--- a/about.pl >+++ b/about.pl >@@ -34,6 +34,7 @@ use C4::Context; > use C4::Installer; > > use Koha; >+use Koha::Borrowers; > use Koha::Config::SysPrefs; > > #use Smart::Comments '####'; >@@ -77,6 +78,9 @@ my $warnPrefAnonymousPatron = ( > and not C4::Context->preference('AnonymousPatron') > ); > >+my $anonymous_patron = Koha::Borrowers->find( C4::Context->preference('AnonymousPatron') ); >+my $warnPrefAnonymousPatron_PatronDoesNotExist = ( not $anonymous_patron and Koha::Borrowers->search({ privacy => 2 })->count ); >+ > my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode(); > > my $warnIsRootUser = (! $loggedinuser); >@@ -227,6 +231,7 @@ $template->param( > warnPrefBiblioAddsAuthorities => $warnPrefBiblioAddsAuthorities, > warnPrefEasyAnalyticalRecords => $warnPrefEasyAnalyticalRecords, > warnPrefAnonymousPatron => $warnPrefAnonymousPatron, >+ warnPrefAnonymousPatron_PatronDoesNotExist => $warnPrefAnonymousPatron_PatronDoesNotExist, > errZebraConnection => $errZebraConnection, > warnIsRootUser => $warnIsRootUser, > warnNoActiveCurrency => $warnNoActiveCurrency, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 90af345..f9f6f7e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -122,6 +122,9 @@ > [% IF warnPrefAnonymousPatron %] > <tr><th scope="row"><b>Warning</b> </th><td>System preference 'OPACPrivacy' set, but AnonymousPatron preference is set to '0'. Set it to a valid borrower number if you want that this feature works correctly.</td></tr> > [% END %] >+ [% IF warnPrefAnonymousPatron_PatronDoesNotExist %] >+ <tr><th scope="row"><b>Warning</b> </th><td>Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly.</td></tr> >+ [% END %] > [% IF warnNoActiveCurrency %] > <tr><th scope="row"><b>Warning</b> </th><td>No active currency is defined. Please go to <a href="/cgi-bin/koha/admin/currency.pl">Administration > Currencies and exchange rates</a> and mark one currency as active.</td></tr> > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14655
:
41630
|
41631
|
42048
|
42049
|
42517
|
42540
| 42541 |
42542