Attachment 42545 Details for Bug 14197 – [PASSED QA] Bug 14197: Remove the warning on destroying TestBuilder objects

[patch] [PASSED QA] Bug 14197: Remove the warning on destroying TestBuilder objects

PASSED-QA-Bug-14197-Remove-the-warning-on-destroyi.patch (text/plain), 1022 bytes, created by Katrin Fischer on 2015-09-14 20:42:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-09-14 20:42:33 UTC

Size: 1022 bytes

patch

obsolete

>From 439f2d7405b46d96c3d9bbf1d94656083cf9847f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@koha-community.org>
>Date: Wed, 13 May 2015 17:58:45 +0200
>Subject: [PATCH] [PASSED QA] Bug 14197: Remove the warning on destroying
> TestBuilder objects
>
>This module will be called by db_dependent tests, which already create a
>transaction.
>TestBuilder creates a new one (which is certainly useless) and the
>rollback does not do anything.
>
>To see the warning see patches on bug 14045.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/lib/TestBuilder.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
>index 5d3157a..72b087d 100644
>--- a/t/lib/TestBuilder.pm
>+++ b/t/lib/TestBuilder.pm
>@@ -357,7 +357,9 @@ sub _gen_blob {
> 
> sub DESTROY {
>     my $self = shift;
>-    $self->schema->txn_rollback();
>+    eval {
>+        $self->schema->txn_rollback();
>+    };
> }
> 
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14197: 39146 | 40859 | 42055 | 42056 | 42057 | 42058 | 42059 | 42545 | 42546