Bugzilla – Attachment 42570 Details for
Bug 14829
Wrong shortcuts in module "cataloging"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14829: Fix shortcuts in the cataloging and patron modules
Bug-14829-Fix-shortcuts-in-the-cataloging-and-patr.patch (text/plain), 3.62 KB, created by
Jonathan Druart
on 2015-09-16 08:04:58 UTC
(
hide
)
Description:
Bug 14829: Fix shortcuts in the cataloging and patron modules
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-09-16 08:04:58 UTC
Size:
3.62 KB
patch
obsolete
>From 49078c644781355f7b0a6d2307de14825f057dd4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 16 Sep 2015 09:01:26 +0100 >Subject: [PATCH] Bug 14829: Fix shortcuts in the cataloging and patron modules > >In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as >in other modules. >The tab are not "built" in the correct order and the id returned to >select the correct tab is wrong. > >Test plan: >Go on the circ home page (circ/circulation-home.pl), the patron home >page (members/members-home.pl) and the cataloging home page >(cataloguing/addbooks.pl). >On these 3 pages, without this patch, the shortcuts select different >tabs. >With this patch, the issue is fixed for all of them. >--- > .../prog/en/includes/cataloging-search.inc | 3 ++- > .../intranet-tmpl/prog/en/includes/patron-search.inc | 18 ++++++++++-------- > 2 files changed, 12 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc >index 1fda946..4b6a9de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc >@@ -10,6 +10,8 @@ > </form> > </div> > >+ [% INCLUDE 'patron-search-box.inc' %] >+ > [% IF ( CAN_user_circulate ) %] > <div id="checkin_search" class="residentsearch"> > <p class="tip">Scan a barcode to check in:</p> >@@ -28,7 +30,6 @@ > </form> > </div> > >- [% INCLUDE 'patron-search-box.inc' %] > <ul> > <li><a onclick="keep_text(0)" href="#addbooks_search">Cataloging search</a></li> > [% IF ( CAN_user_circulate ) %]<li><a onclick="keep_text(1)" href="#circ_search">Check out</a></li>[% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index 646c70a..67acaa5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -109,14 +109,6 @@ > </div> > [% INCLUDE 'patron-search-box.inc' %] > >- [% IF ( CAN_user_catalogue ) %] >- <div id="catalog_search" class="residentsearch"> >- <p class="tip">Enter search keywords:</p> >- <form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block"> >- <input type="text" name="q" id="search-form" size="40" value="" title="Enter the terms you wish to search for." class="head-searchbox form-text" /> >- <input type="submit" name="op" id="opac-submit" value="Submit" class="submit" /> >- </form> >- </div>[% END %] > [% IF ( CAN_user_circulate ) %] > <div id="checkin_search" class="residentsearch"> > <p class="tip">Scan a barcode to check in:</p> >@@ -126,6 +118,16 @@ > </form> > </div> > [% END %] >+ >+ [% IF ( CAN_user_catalogue ) %] >+ <div id="catalog_search" class="residentsearch"> >+ <p class="tip">Enter search keywords:</p> >+ <form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block"> >+ <input type="text" name="q" id="search-form" size="40" value="" title="Enter the terms you wish to search for." class="head-searchbox form-text" /> >+ <input type="submit" name="op" id="opac-submit" value="Submit" class="submit" /> >+ </form> >+ </div>[% END %] >+ > <ul> > <li><a onclick="keep_text(0)" href="#patron_search">Search patrons</a></li> > [% IF ( CAN_user_circulate ) %]<li><a onclick="keep_text(1)" href="#circ_search">Check out</a></li>[% END %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14829
:
42570
|
42585
|
42981