Bugzilla – Attachment 42579 Details for
Bug 12252
OAI-PMH GetRecord result doesn't include item data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12252: (qa-follow-up) Remove perlcritic error
Bug-12252-qa-follow-up-Remove-perlcritic-error.patch (text/plain), 1.37 KB, created by
Jonathan Druart
on 2015-09-16 09:53:19 UTC
(
hide
)
Description:
Bug 12252: (qa-follow-up) Remove perlcritic error
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-09-16 09:53:19 UTC
Size:
1.37 KB
patch
obsolete
>From 221709a0d74f1a389968a35037adc342a2b14f34 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 7 Jan 2015 15:29:50 +0100 >Subject: [PATCH] Bug 12252: (qa-follow-up) Remove perlcritic error > >Signed-off-by: Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Biblio.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 25558d6..191e9c7 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -2943,12 +2943,13 @@ sub EmbedItemsInMarcBiblio { > require C4::Items; > while ( my ($itemnumber) = $sth->fetchrow_array ) { > next if @$itemnumbers and not grep { $_ == $itemnumber } @$itemnumbers; >- my $i = C4::Items::GetItem($itemnumber) if $opachiddenitems; >+ my $i = $opachiddenitems ? C4::Items::GetItem($itemnumber) : undef; > push @items, { itemnumber => $itemnumber, item => $i }; > } > my @hiddenitems = >- C4::Items::GetHiddenItemnumbers( map { $_->{item} } @items ) >- if $opachiddenitems; >+ $opachiddenitems >+ ? C4::Items::GetHiddenItemnumbers( map { $_->{item} } @items ) >+ : (); > # Convert to a hash for quick searching > my %hiddenitems = map { $_ => 1 } @hiddenitems; > foreach my $itemnumber ( map { $_->{itemnumber} } @items ) { >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12252
:
28228
|
28229
|
28243
|
28344
|
28345
|
29159
|
29160
|
33120
|
33121
|
33122
|
34890
|
35006
|
35007
|
35008
|
35009
|
35010
|
35011
|
41135
|
41136
|
41137
|
41138
|
41139
|
41140
|
41175
|
41176
|
41177
|
41178
|
41179
|
41180
|
42018
|
42019
|
42020
|
42021
|
42022
|
42023
|
42024
|
42314
|
42575
|
42576
|
42577
|
42578
| 42579 |
42580
|
42581