Attachment 42586 Details for Bug 14245 – Bug 14245: Problems with RIS export in unimarc

[patch] Bug 14245: Problems with RIS export in unimarc

Bug-14245-Problems-with-RIS-export-in-unimarc.patch (text/plain), 2.16 KB, created by Jonathan Druart on 2015-09-16 11:08:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-09-16 11:08:31 UTC

Size: 2.16 KB

patch

obsolete

>From 03560c316008ceba5cc44191d0d9e0658ba33f4a Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Thu, 21 May 2015 14:00:05 -0300
>Subject: [PATCH] Bug 14245: Problems with RIS export in unimarc
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Variable $itype is used an all C4/Ris.pm to switch
>between marc falvors, but is local and not passed along
>as argument.
>
>As a quick solution, is defined as global
>
>To test:
>1) On UNIMARC setup, export a record as RIS,
>check that author (and other fields) are displayed
>incorrectly
>
>2) Apply the patch
>
>3) Export again, improved results
>
>4) Run t/Ris.t
>
>There are other problems in this script, needs maintenance
>(e.g. no Modern::Perl friendly)
>
>Signed-off-by: Victor do RosÃ¡rio <jvr@fct.unl.pt>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Ris.pm | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Ris.pm b/C4/Ris.pm
>index 086486f..db8ca58 100644
>--- a/C4/Ris.pm
>+++ b/C4/Ris.pm
>@@ -94,12 +94,14 @@ C<$record> - a MARC::Record object
> 
> =cut
> 
>+my $intype;
>+
> sub marc2ris {
>     my ($record) = @_;
>     my $output;
> 
>     my $marcflavour = C4::Context->preference("marcflavour");
>-    my $intype = lc($marcflavour);
>+    $intype = lc($marcflavour);
>     my $marcprint = 0; # Debug flag;
> 
>     # Let's redirect stdout
>@@ -457,7 +459,7 @@ sub normalize_author {
> 
> 	## we currently ignore subfield c until someone complains
> 	if (length($rawauthorb) > 0) {
>-	    return join ",", ($rawauthora, $rawauthorb);
>+        return join ", ", ($rawauthora, $rawauthorb);
> 	}
> 	else {
> 	    return $rawauthora;
>@@ -496,7 +498,7 @@ sub get_author {
> 	normalize_author($authorname, $authorfield->subfield('b'), $authorfield->subfield('c'), $authorfield->indicator("$indicator"));
>     }
>     else {
>-	normalize_author($authorfield->subfield('a'), $authorfield->subfield('b'), $authorfield->subfield('c'), $authorfield->indicator("$indicator"));
>+        normalize_author($authorfield->subfield('a') // '', $authorfield->subfield('b') // '', $authorfield->subfield('c') // '', $authorfield->indicator("$indicator"));
>     }
> }
> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14245: 39360 | 39366 | 42572 | 42586 | 42608