Attachment 42587 Details for Bug 14321 – Bug 14321: QA Fix

[patch] Bug 14321: QA Fix

Bug-14321-QA-Fix.patch (text/plain), 1.68 KB, created by Marcel de Rooy on 2015-09-16 12:09:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-09-16 12:09:25 UTC

Size: 1.68 KB

patch

obsolete

>From 0f23a178b4856998bc5627613b7a824976cb78fa Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 16 Sep 2015 11:12:04 +0100
>Subject: [PATCH] Bug 14321: QA Fix
>Content-Type: text/plain; charset=utf-8
>
>Remove QA errors (keys on reference is experimental).
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Upload.pm |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Upload.pm b/Koha/Upload.pm
>index e30b354..9b580ec 100644
>--- a/Koha/Upload.pm
>+++ b/Koha/Upload.pm
>@@ -122,7 +122,7 @@ sub cgi {
> 
> sub count {
>     my ( $self ) = @_;
>-    return scalar grep { !exists $self->{files}->{$_}->{errcode} } keys $self->{files};
>+    return scalar grep { !exists $self->{files}->{$_}->{errcode} } keys %{ $self->{files} };
> }
> 
> =head2 result
>@@ -135,7 +135,7 @@ sub result {
>     my ( $self ) = @_;
>     my @a = map { $self->{files}->{$_}->{id} }
>         grep { !exists $self->{files}->{$_}->{errcode} }
>-        keys $self->{files};
>+        keys %{ $self->{files} };
>     return @a? ( join ',', @a ): undef;
> }
> 
>@@ -149,7 +149,7 @@ sub result {
> sub err {
>     my ( $self ) = @_;
>     my $err;
>-    foreach my $f ( keys $self->{files} ) {
>+    foreach my $f ( keys %{ $self->{files} } ) {
>         my $e = $self->{files}->{$f}->{errcode};
>         $err->{ $f } = $e if $e;
>     }
>@@ -328,7 +328,7 @@ sub _hook {
> sub _done {
>     my ( $self ) = @_;
>     $self->{done} = 1;
>-    foreach my $f ( keys $self->{files} ) {
>+    foreach my $f ( keys %{ $self->{files} } ) {
>         my $fh = $self->_fh($f);
>         $self->_register( $f, $fh? tell( $fh ): undef )
>             if !$self->{files}->{$f}->{errcode};
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14321: 41498 | 41499 | 41500 | 41501 | 41555 | 41556 | 41557 | 41558 | 41559 | 41560 | 41561 | 41562 | 41665 | 41666 | 41667 | 41668 | 41669 | 41677 | 41873 | 41874 | 41875 | 41876 | 41877 | 41878 | 41879 | 41880 | 41881 | 42411 | 42412 | 42413 | 42414 | 42558 | 42559 | 42560 | 42561 | 42584 | 42587 | 42588 | 42589 | 42590 | 42591 | 42660 | 42661 | 42662 | 42663 | 42664 | 42665 | 42666 | 42707 | 42726 | 42727 | 42728 | 42729 | 42730 | 42731 | 42732 | 42889 | 42890