Attachment 4260 Details for Bug 6409 – proposed bugfix

[patch] proposed bugfix

0001-bug-6409-fix-pagination-of-SQL-report-output-when-pa.patch (text/plain), 1.39 KB, created by Galen Charlton on 2011-05-25 18:47:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Galen Charlton

Created: 2011-05-25 18:47:21 UTC

Size: 1.39 KB

patch

obsolete

>From cb3ca1b2b08bfba052f48d61b4cf64f7510c5f63 Mon Sep 17 00:00:00 2001
>From: Galen Charlton <gmcharlt@gmail.com>
>Date: Wed, 25 May 2011 14:42:48 -0400
>Subject: [PATCH] bug 6409: fix pagination of SQL report output when parameters are used
>
>Fixes bug where paging through output of an SQL report that includes
>one or more parameters fails by asking you for the parameter values
>and again and sending you back to the first page of results.
>
>Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
>---
> reports/guided_reports.pl |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index 600ac29..582c0dc 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -21,6 +21,7 @@ use strict;
> #use warnings; FIXME - Bug 2505
> use CGI;
> use Text::CSV;
>+use URI::Escape;
> use C4::Reports::Guided;
> use C4::Auth qw/:DEFAULT get_session/;
> use C4::Output;
>@@ -521,6 +522,9 @@ elsif ($phase eq 'Run this report'){
> 
>         my $totpages = int($total/$limit) + (($total % $limit) > 0 ? 1 : 0);
>         my $url = "/cgi-bin/koha/reports/guided_reports.pl?reports=$report&amp;phase=Run%20this%20report";
>+        if (@sql_params) {
>+            $url = join('&amp;sql_params=', $url, map { URI::Escape::uri_escape($_) } @sql_params);
>+        }
>         $template->param(
>             'results' => \@rows,
>             'sql'     => $sql,
>-- 
>1.7.2.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 6409: 4260